From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Hans de Bruin <jmdebruin@xmsnet.nl>, linux-input@vger.kernel.org
Subject: Re: [PATCH] alps: Document separate pointstick button bits for V2 alps devices
Date: Tue, 14 Apr 2015 09:08:51 -0700 [thread overview]
Message-ID: <20150414160851.GA24687@dtor-glaptop> (raw)
In-Reply-To: <1428996947-4454-1-git-send-email-hdegoede@redhat.com>
On Tue, Apr 14, 2015 at 09:35:47AM +0200, Hans de Goede wrote:
> Non interleaved dualpoint v2 devices have separate pointstick button bits,
> document this.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Documentation/input/alps.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/input/alps.txt b/Documentation/input/alps.txt
> index 92ae734..776a099 100644
> --- a/Documentation/input/alps.txt
> +++ b/Documentation/input/alps.txt
> @@ -107,7 +107,7 @@ ALPS Absolute Mode - Protocol Version 1
> ALPS Absolute Mode - Protocol Version 2
> ---------------------------------------
>
> - byte 0: 1 ? ? ? 1 ? ? ?
> + byte 0: 1 ? ? ? 1 PSM PSR PSL
> byte 1: 0 x6 x5 x4 x3 x2 x1 x0
> byte 2: 0 x10 x9 x8 x7 ? fin ges
> byte 3: 0 y9 y8 y7 1 M R L
> @@ -115,7 +115,8 @@ ALPS Absolute Mode - Protocol Version 2
> byte 5: 0 z6 z5 z4 z3 z2 z1 z0
>
> Protocol Version 2 DualPoint devices send standard PS/2 mouse packets for
> -the DualPoint Stick.
> +the DualPoint Stick. For non interleaved dualpoint devices the pointingstick
> +buttons get reported separately in the PSM, PSR and PSL bits.
Can you please also add explanation about trackstick still using the mix of both?
Thanks!
--
Dmitry
prev parent reply other threads:[~2015-04-14 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 7:35 [PATCH] alps: Document separate pointstick button bits for V2 alps devices Hans de Goede
2015-04-14 16:08 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414160851.GA24687@dtor-glaptop \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jmdebruin@xmsnet.nl \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).