linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] alps: Document separate pointstick button bits for V2 alps devices
@ 2015-04-14  7:35 Hans de Goede
  2015-04-14 16:08 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2015-04-14  7:35 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: Hans de Bruin, linux-input, Hans de Goede

Non interleaved dualpoint v2 devices have separate pointstick button bits,
document this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 Documentation/input/alps.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/input/alps.txt b/Documentation/input/alps.txt
index 92ae734..776a099 100644
--- a/Documentation/input/alps.txt
+++ b/Documentation/input/alps.txt
@@ -107,7 +107,7 @@ ALPS Absolute Mode - Protocol Version 1
 ALPS Absolute Mode - Protocol Version 2
 ---------------------------------------
 
- byte 0:  1    ?    ?    ?    1    ?    ?    ?
+ byte 0:  1    ?    ?    ?    1  PSM  PSR  PSL
  byte 1:  0   x6   x5   x4   x3   x2   x1   x0
  byte 2:  0  x10   x9   x8   x7    ?  fin  ges
  byte 3:  0   y9   y8   y7    1    M    R    L
@@ -115,7 +115,8 @@ ALPS Absolute Mode - Protocol Version 2
  byte 5:  0   z6   z5   z4   z3   z2   z1   z0
 
 Protocol Version 2 DualPoint devices send standard PS/2 mouse packets for
-the DualPoint Stick.
+the DualPoint Stick. For non interleaved dualpoint devices the pointingstick
+buttons get reported separately in the PSM, PSR and PSL bits.
 
 Dualpoint device -- interleaved packet format
 ---------------------------------------------
-- 
2.3.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] alps: Document separate pointstick button bits for V2 alps devices
  2015-04-14  7:35 [PATCH] alps: Document separate pointstick button bits for V2 alps devices Hans de Goede
@ 2015-04-14 16:08 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-04-14 16:08 UTC (permalink / raw)
  To: Hans de Goede; +Cc: Hans de Bruin, linux-input

On Tue, Apr 14, 2015 at 09:35:47AM +0200, Hans de Goede wrote:
> Non interleaved dualpoint v2 devices have separate pointstick button bits,
> document this.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  Documentation/input/alps.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/input/alps.txt b/Documentation/input/alps.txt
> index 92ae734..776a099 100644
> --- a/Documentation/input/alps.txt
> +++ b/Documentation/input/alps.txt
> @@ -107,7 +107,7 @@ ALPS Absolute Mode - Protocol Version 1
>  ALPS Absolute Mode - Protocol Version 2
>  ---------------------------------------
>  
> - byte 0:  1    ?    ?    ?    1    ?    ?    ?
> + byte 0:  1    ?    ?    ?    1  PSM  PSR  PSL
>   byte 1:  0   x6   x5   x4   x3   x2   x1   x0
>   byte 2:  0  x10   x9   x8   x7    ?  fin  ges
>   byte 3:  0   y9   y8   y7    1    M    R    L
> @@ -115,7 +115,8 @@ ALPS Absolute Mode - Protocol Version 2
>   byte 5:  0   z6   z5   z4   z3   z2   z1   z0
>  
>  Protocol Version 2 DualPoint devices send standard PS/2 mouse packets for
> -the DualPoint Stick.
> +the DualPoint Stick. For non interleaved dualpoint devices the pointingstick
> +buttons get reported separately in the PSM, PSR and PSL bits.

Can you please also add explanation about trackstick still using the mix of both?

Thanks!

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-14 16:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-14  7:35 [PATCH] alps: Document separate pointstick button bits for V2 alps devices Hans de Goede
2015-04-14 16:08 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).