* [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name
@ 2015-04-18 3:43 Dmitry Torokhov
2015-04-20 17:02 ` Charles Mooney
2015-04-20 19:27 ` Benson Leung
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2015-04-18 3:43 UTC (permalink / raw)
To: linux-input; +Cc: Scott Liu, Charlie Mooney, linux-kernel
Let's zero-extend hardware id number when forming firmware file name,
to avoid kernel requesting firmware like "elants_i2c_ 0.bin", which
is quite unexpected.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/elants_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index 43b3c9c..0efd766 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -699,7 +699,7 @@ static int elants_i2c_fw_update(struct elants_data *ts)
char *fw_name;
int error;
- fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%4x.bin", ts->hw_version);
+ fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%04x.bin", ts->hw_version);
if (!fw_name)
return -ENOMEM;
--
2.2.0.rc0.207.ga3a616c
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name
2015-04-18 3:43 [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name Dmitry Torokhov
@ 2015-04-20 17:02 ` Charles Mooney
2015-04-20 19:27 ` Benson Leung
1 sibling, 0 replies; 3+ messages in thread
From: Charles Mooney @ 2015-04-20 17:02 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Scott Liu, Linux Kernel Mailing List
On Fri, Apr 17, 2015 at 8:43 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> Let's zero-extend hardware id number when forming firmware file name,
> to avoid kernel requesting firmware like "elants_i2c_ 0.bin", which
> is quite unexpected.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/touchscreen/elants_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
> index 43b3c9c..0efd766 100644
> --- a/drivers/input/touchscreen/elants_i2c.c
> +++ b/drivers/input/touchscreen/elants_i2c.c
> @@ -699,7 +699,7 @@ static int elants_i2c_fw_update(struct elants_data *ts)
> char *fw_name;
> int error;
>
> - fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%4x.bin", ts->hw_version);
> + fw_name = kasprintf(GFP_KERNEL, "elants_i2c_%04x.bin", ts->hw_version);
> if (!fw_name)
> return -ENOMEM;
>
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry
Looks good to me.
Acked-by: Charlie Mooney<charliemooney@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name
2015-04-18 3:43 [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name Dmitry Torokhov
2015-04-20 17:02 ` Charles Mooney
@ 2015-04-20 19:27 ` Benson Leung
1 sibling, 0 replies; 3+ messages in thread
From: Benson Leung @ 2015-04-20 19:27 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-input@vger.kernel.org, Scott Liu, Charlie Mooney,
linux-kernel@vger.kernel.org
On Fri, Apr 17, 2015 at 8:43 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> Let's zero-extend hardware id number when forming firmware file name,
> to avoid kernel requesting firmware like "elants_i2c_ 0.bin", which
> is quite unexpected.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
--
Benson Leung
Software Engineer, Chrom* OS
bleung@chromium.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-20 19:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-18 3:43 [PATCH] Input: elants_i2c - zero-extend hardware ID in firmware name Dmitry Torokhov
2015-04-20 17:02 ` Charles Mooney
2015-04-20 19:27 ` Benson Leung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).