From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input - elantech: fix semi-mt protocol for v3 HW
Date: Thu, 23 Apr 2015 09:09:55 -0700 [thread overview]
Message-ID: <20150423160955.GB34808@dtor-ws> (raw)
In-Reply-To: <1429717509-27396-2-git-send-email-benjamin.tissoires@redhat.com>
On Wed, Apr 22, 2015 at 11:45:08AM -0400, Benjamin Tissoires wrote:
> When the v3 hardware sees more than one finger, it uses
> the semi-mt protocol to report the touches. However, it
> currently works when num_fingers is 0, 1 or 2, but when
> it is 3 and above, it sends only 1 finger as if num_fingers
> was 1.
>
> This confuses userspace which knows how to deal with extra
> fingers when all the slots are used, but not when some are
> missing.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=90101
>
> CC: stable@vger.kernel.org
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied, thank you.
> ---
> drivers/input/mouse/elantech.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index 991dc6b..79363b6 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -315,7 +315,7 @@ static void elantech_report_semi_mt_data(struct input_dev *dev,
> unsigned int x2, unsigned int y2)
> {
> elantech_set_slot(dev, 0, num_fingers != 0, x1, y1);
> - elantech_set_slot(dev, 1, num_fingers == 2, x2, y2);
> + elantech_set_slot(dev, 1, num_fingers >= 2, x2, y2);
> }
>
> /*
> --
> 2.1.0
>
--
Dmitry
next prev parent reply other threads:[~2015-04-23 16:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 15:45 [PATCH 0/2] 2 somewhat related input fixes Benjamin Tissoires
2015-04-22 15:45 ` [PATCH 1/2] Input - elantech: fix semi-mt protocol for v3 HW Benjamin Tissoires
2015-04-23 16:09 ` Dmitry Torokhov [this message]
2015-04-22 15:45 ` [PATCH 2/2] Input - synaptics: pin 3 touches when the firmware reports 3 fingers Benjamin Tissoires
2015-04-23 16:38 ` Dmitry Torokhov
2015-04-23 18:48 ` Benjamin Tissoires
2015-04-24 22:50 ` Benjamin Tissoires
2015-04-25 9:40 ` Henrik Rydberg
2015-04-27 17:48 ` Benjamin Tissoires
2015-06-11 17:29 ` Benjamin Tissoires
2015-07-01 0:26 ` Dmitry Torokhov
2015-07-07 14:02 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423160955.GB34808@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox