From: Pavel Machek <pavel@ucw.cz>
To: Frank Praznik <frank.praznik@oh.rr.com>
Cc: linux-input@vger.kernel.org, jkosina@suse.cz
Subject: Re: [PATCH v2 1/6] hid: sony: Prevent the freeing of an unitialized ida value
Date: Wed, 6 May 2015 11:24:34 +0200 [thread overview]
Message-ID: <20150506092434.GA4508@amd> (raw)
In-Reply-To: <1430873253-11765-2-git-send-email-frank.praznik@oh.rr.com>
Hi!
> sony_allocate_output_report() was being called before sony_set_device_id()
> which meant that an unallocated ida value was was freed if the output
> report allocation failed and the probe function jumped to err_stop.
>
> Do the device ID allocation before the output report allocation to avoid
> freeing an unallocated value in case of a failure.
>
> Signed-off-by: Frank Praznik <frank.praznik@oh.rr.com>
The series looks good to me, thanks a lot.
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-05-06 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 0:47 [PATCH v2 0/5] Support for the Sony Motion Controller and other cleanups Frank Praznik
2015-05-06 0:47 ` [PATCH v2 1/6] hid: sony: Prevent the freeing of an unitialized ida value Frank Praznik
2015-05-06 9:24 ` Pavel Machek [this message]
2015-05-06 0:47 ` [PATCH v2 2/6] hid: sony: Add the product ID for the Sony Motion Controller Frank Praznik
2015-05-06 0:47 ` [PATCH v2 3/6] hid: sony: Add support " Frank Praznik
2015-05-06 0:47 ` [PATCH v2 4/6] hid: sony: Correct Sony device ordering Frank Praznik
2015-05-06 0:47 ` [PATCH v2 5/6] hid: sony: Simplify LED initialization and eliminate redundant copies when updating LED states Frank Praznik
2015-05-06 0:47 ` [PATCH v2 6/6] hid: sony: Correct a typo in a HID descriptor comment and explain the odd Sixaxis axis mapping Frank Praznik
2015-05-07 8:43 ` [PATCH v2 0/5] Support for the Sony Motion Controller and other cleanups Jiri Kosina
2015-05-27 15:46 ` simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506092434.GA4508@amd \
--to=pavel@ucw.cz \
--cc=frank.praznik@oh.rr.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).