* [PATCH v2] input: goodix: Check the 'buffer status' bit before reading data
@ 2015-05-01 12:40 Paul Cercueil
2015-05-01 14:13 ` Bastien Nocera
0 siblings, 1 reply; 3+ messages in thread
From: Paul Cercueil @ 2015-05-01 12:40 UTC (permalink / raw)
To: Bastien Nocera, Dmitry Torokhov; +Cc: linux-input, linux-kernel, Paul Cercueil
The MSB of the first byte read via I2C at the coordinates address
indicates whether the data is valid or ready (called "buffer status" in
the datasheets) when an interrupt is raised. Previously, this bit was
ignored, which resulted in a lot of incorrect detections of "finger
removed" events.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
v2: Fix commit message
drivers/input/touchscreen/goodix.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index ca19668..9fa6c5f 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -98,6 +98,9 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data)
return error;
}
+ if (!(data[0] & 0x80))
+ return -EAGAIN;
+
touch_num = data[0] & 0x0f;
if (touch_num > GOODIX_MAX_CONTACTS)
return -EPROTO;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] input: goodix: Check the 'buffer status' bit before reading data
2015-05-01 12:40 [PATCH v2] input: goodix: Check the 'buffer status' bit before reading data Paul Cercueil
@ 2015-05-01 14:13 ` Bastien Nocera
2015-05-06 23:54 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Bastien Nocera @ 2015-05-01 14:13 UTC (permalink / raw)
To: Paul Cercueil; +Cc: Dmitry Torokhov, linux-input, linux-kernel
On Fri, 2015-05-01 at 14:40 +0200, Paul Cercueil wrote:
> The MSB of the first byte read via I2C at the coordinates address
> indicates whether the data is valid or ready (called "buffer status"
> in
> the datasheets) when an interrupt is raised. Previously, this bit was
> ignored, which resulted in a lot of incorrect detections of "finger
> removed" events.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Bastien Nocera <hadess@hadess.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] input: goodix: Check the 'buffer status' bit before reading data
2015-05-01 14:13 ` Bastien Nocera
@ 2015-05-06 23:54 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2015-05-06 23:54 UTC (permalink / raw)
To: Bastien Nocera; +Cc: Paul Cercueil, linux-input, linux-kernel
On Fri, May 01, 2015 at 04:13:55PM +0200, Bastien Nocera wrote:
> On Fri, 2015-05-01 at 14:40 +0200, Paul Cercueil wrote:
> > The MSB of the first byte read via I2C at the coordinates address
> > indicates whether the data is valid or ready (called "buffer status"
> > in
> > the datasheets) when an interrupt is raised. Previously, this bit was
> > ignored, which resulted in a lot of incorrect detections of "finger
> > removed" events.
> >
> > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-06 23:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-01 12:40 [PATCH v2] input: goodix: Check the 'buffer status' bit before reading data Paul Cercueil
2015-05-01 14:13 ` Bastien Nocera
2015-05-06 23:54 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).