[PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Marek Vasut]

Use msecs_to_jiffies(20) instead of plain (HZ / 50), as the
former is much more explicit about it's behavior. We want
to schedule the task 20 mS from now, so make it explicit in
the code.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/stmpe-ts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index 42ce31a..9e5c880 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -164,7 +164,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
 			STMPE_TSC_CTRL_TSC_EN, STMPE_TSC_CTRL_TSC_EN);
 
 	/* start polling for touch_det to detect release */
-	schedule_delayed_work(&ts->work, HZ / 50);
+	schedule_delayed_work(&ts->work, msecs_to_jiffies(20));
 
 	return IRQ_HANDLED;
 }
-- 
2.1.4

[PATCH 2/2] Input: smtpe-ts: Wait 50mS until polling for pen-up

[Marek Vasut]

Wait a little bit longer, 50mS instead of 20mS, until the driver
starts polling for pen-up. The problematic behavior before this
patch is applied is as follows. The behavior was observed on the
STMPE610QTR controller.

Upon a physical pen-down event, the touchscreen reports one set
of x-y-p coordinates and a pen-down event. After that, the pen-up
polling is triggered and since the controller is not ready yet,
the polling mistakenly detects a pen-up event while the physical
state is still such that the pen is down on the touch surface.

The pen-up handling flushes the controller FIFO, so after that,
all the samples in the controller are discarded. The controller
becomes ready shortly after this bogus pen-up handling and does
generate again a pen-down interrupt. This time, the controller
contains x-y-p samples which all read as zero. Since pressure
value is zero, this set of samples is effectively ignored by
userland.

In the end, the driver just bounces between pen-down and bogus
pen-up handling, generating no useful results. Fix this by giving
the controller a bit more time before polling it for pen-up.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/stmpe-ts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index 9e5c880..a8f5ea7 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -164,7 +164,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data)
 			STMPE_TSC_CTRL_TSC_EN, STMPE_TSC_CTRL_TSC_EN);
 
 	/* start polling for touch_det to detect release */
-	schedule_delayed_work(&ts->work, msecs_to_jiffies(20));
+	schedule_delayed_work(&ts->work, msecs_to_jiffies(50));
 
 	return IRQ_HANDLED;
 }
-- 
2.1.4

Re: [PATCH 2/2] Input: smtpe-ts: Wait 50mS until polling for pen-up

[Viresh Kumar]

On 8 May 2015 at 07:23, Marek Vasut <marex@denx.de> wrote:
> Wait a little bit longer, 50mS instead of 20mS, until the driver
> starts polling for pen-up. The problematic behavior before this
> patch is applied is as follows. The behavior was observed on the
> STMPE610QTR controller.
>
> Upon a physical pen-down event, the touchscreen reports one set
> of x-y-p coordinates and a pen-down event. After that, the pen-up
> polling is triggered and since the controller is not ready yet,
> the polling mistakenly detects a pen-up event while the physical
> state is still such that the pen is down on the touch surface.
>
> The pen-up handling flushes the controller FIFO, so after that,
> all the samples in the controller are discarded. The controller
> becomes ready shortly after this bogus pen-up handling and does
> generate again a pen-down interrupt. This time, the controller
> contains x-y-p samples which all read as zero. Since pressure
> value is zero, this set of samples is effectively ignored by
> userland.
>
> In the end, the driver just bounces between pen-down and bogus
> pen-up handling, generating no useful results. Fix this by giving
> the controller a bit more time before polling it for pen-up.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/touchscreen/stmpe-ts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Viresh Kumar]

On 8 May 2015 at 07:23, Marek Vasut <marex@denx.de> wrote:
> Use msecs_to_jiffies(20) instead of plain (HZ / 50), as the
> former is much more explicit about it's behavior. We want
> to schedule the task 20 mS from now, so make it explicit in
> the code.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/touchscreen/stmpe-ts.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Dmitry Torokhov]

On Fri, May 08, 2015 at 07:45:48AM +0530, Viresh Kumar wrote:
> On 8 May 2015 at 07:23, Marek Vasut <marex@denx.de> wrote:
> > Use msecs_to_jiffies(20) instead of plain (HZ / 50), as the
> > former is much more explicit about it's behavior. We want
> > to schedule the task 20 mS from now, so make it explicit in
> > the code.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >  drivers/input/touchscreen/stmpe-ts.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied both, thank you.

-- 
Dmitry

Re: [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Marek Vasut]

On Friday, May 08, 2015 at 07:28:20 AM, Dmitry Torokhov wrote:
> On Fri, May 08, 2015 at 07:45:48AM +0530, Viresh Kumar wrote:
> > On 8 May 2015 at 07:23, Marek Vasut <marex@denx.de> wrote:
> > > Use msecs_to_jiffies(20) instead of plain (HZ / 50), as the
> > > former is much more explicit about it's behavior. We want
> > > to schedule the task 20 mS from now, so make it explicit in
> > > the code.
> > > 
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > ---
> > > 
> > >  drivers/input/touchscreen/stmpe-ts.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Applied both, thank you.

Thank you! Shall I submit them for -stable as well please ?

Best regards,
Marek Vasut

Re: [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Dmitry Torokhov]

On Fri, May 08, 2015 at 11:47:39AM +0200, Marek Vasut wrote:
> On Friday, May 08, 2015 at 07:28:20 AM, Dmitry Torokhov wrote:
> > On Fri, May 08, 2015 at 07:45:48AM +0530, Viresh Kumar wrote:
> > > On 8 May 2015 at 07:23, Marek Vasut <marex@denx.de> wrote:
> > > > Use msecs_to_jiffies(20) instead of plain (HZ / 50), as the
> > > > former is much more explicit about it's behavior. We want
> > > > to schedule the task 20 mS from now, so make it explicit in
> > > > the code.
> > > > 
> > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > ---
> > > > 
> > > >  drivers/input/touchscreen/stmpe-ts.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> > 
> > Applied both, thank you.
> 
> Thank you! Shall I submit them for -stable as well please ?

Please.

-- 
Dmitry

Re: [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Marek Vasut]

On Friday, May 08, 2015 at 07:22:28 PM, Dmitry Torokhov wrote:
> On Fri, May 08, 2015 at 11:47:39AM +0200, Marek Vasut wrote:
> > On Friday, May 08, 2015 at 07:28:20 AM, Dmitry Torokhov wrote:
> > > On Fri, May 08, 2015 at 07:45:48AM +0530, Viresh Kumar wrote:
> > > > On 8 May 2015 at 07:23, Marek Vasut <marex@denx.de> wrote:
> > > > > Use msecs_to_jiffies(20) instead of plain (HZ / 50), as the
> > > > > former is much more explicit about it's behavior. We want
> > > > > to schedule the task 20 mS from now, so make it explicit in
> > > > > the code.
> > > > > 
> > > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > > Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > > > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > > ---
> > > > > 
> > > > >  drivers/input/touchscreen/stmpe-ts.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > 
> > > Applied both, thank you.
> > 
> > Thank you! Shall I submit them for -stable as well please ?
> 
> Please.

Hi,

these patches still didn't make it for Linus's tree. I cannot submit
to -stable unless they hit Linus's tree to my knowledge. Shall I wait
some more please ?

Thank you!

Best regards,
Marek Vasut

Re: [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Dmitry Torokhov]

On Fri, May 22, 2015 at 01:58:34AM +0200, Marek Vasut wrote:
> On Friday, May 08, 2015 at 07:22:28 PM, Dmitry Torokhov wrote:
> > On Fri, May 08, 2015 at 11:47:39AM +0200, Marek Vasut wrote:
> > > On Friday, May 08, 2015 at 07:28:20 AM, Dmitry Torokhov wrote:
> > > > On Fri, May 08, 2015 at 07:45:48AM +0530, Viresh Kumar wrote:
> > > > > On 8 May 2015 at 07:23, Marek Vasut <marex@denx.de> wrote:
> > > > > > Use msecs_to_jiffies(20) instead of plain (HZ / 50), as the
> > > > > > former is much more explicit about it's behavior. We want
> > > > > > to schedule the task 20 mS from now, so make it explicit in
> > > > > > the code.
> > > > > > 
> > > > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > > > Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > > > > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > > > ---
> > > > > > 
> > > > > >  drivers/input/touchscreen/stmpe-ts.c | 2 +-
> > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > > 
> > > > Applied both, thank you.
> > > 
> > > Thank you! Shall I submit them for -stable as well please ?
> > 
> > Please.
> 
> Hi,
> 
> these patches still didn't make it for Linus's tree. I cannot submit
> to -stable unless they hit Linus's tree to my knowledge. Shall I wait
> some more please ?

They are in -next. I guess I could get them in 4.1...

-- 
Dmitry

Re: [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Marek Vasut]

On Friday, May 22, 2015 at 02:01:21 AM, Dmitry Torokhov wrote:
> On Fri, May 22, 2015 at 01:58:34AM +0200, Marek Vasut wrote:
> > On Friday, May 08, 2015 at 07:22:28 PM, Dmitry Torokhov wrote:
> > > On Fri, May 08, 2015 at 11:47:39AM +0200, Marek Vasut wrote:
> > > > On Friday, May 08, 2015 at 07:28:20 AM, Dmitry Torokhov wrote:
> > > > > On Fri, May 08, 2015 at 07:45:48AM +0530, Viresh Kumar wrote:
> > > > > > On 8 May 2015 at 07:23, Marek Vasut <marex@denx.de> wrote:
> > > > > > > Use msecs_to_jiffies(20) instead of plain (HZ / 50), as the
> > > > > > > former is much more explicit about it's behavior. We want
> > > > > > > to schedule the task 20 mS from now, so make it explicit in
> > > > > > > the code.
> > > > > > > 
> > > > > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > > > > Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > > > > > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > > > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > > > > ---
> > > > > > > 
> > > > > > >  drivers/input/touchscreen/stmpe-ts.c | 2 +-
> > > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > 
> > > > > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > > > 
> > > > > Applied both, thank you.
> > > > 
> > > > Thank you! Shall I submit them for -stable as well please ?
> > > 
> > > Please.
> > 
> > Hi,
> > 
> > these patches still didn't make it for Linus's tree. I cannot submit
> > to -stable unless they hit Linus's tree to my knowledge. Shall I wait
> > some more please ?
> 
> They are in -next. I guess I could get them in 4.1...

In case it's not much of a hassle for everyone involved, it would be nice.
Otherwise, I will just wait for 4.2 merge window to open and submit for
stable after that. Just let me know what you prefer and I will do so.

Best regards,
Marek Vasut

Re: [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Dmitry Torokhov]

On Fri, May 22, 2015 at 02:05:52AM +0200, Marek Vasut wrote:
> On Friday, May 22, 2015 at 02:01:21 AM, Dmitry Torokhov wrote:
> > On Fri, May 22, 2015 at 01:58:34AM +0200, Marek Vasut wrote:
> > > On Friday, May 08, 2015 at 07:22:28 PM, Dmitry Torokhov wrote:
> > > > On Fri, May 08, 2015 at 11:47:39AM +0200, Marek Vasut wrote:
> > > > > On Friday, May 08, 2015 at 07:28:20 AM, Dmitry Torokhov wrote:
> > > > > > On Fri, May 08, 2015 at 07:45:48AM +0530, Viresh Kumar wrote:
> > > > > > > On 8 May 2015 at 07:23, Marek Vasut <marex@denx.de> wrote:
> > > > > > > > Use msecs_to_jiffies(20) instead of plain (HZ / 50), as the
> > > > > > > > former is much more explicit about it's behavior. We want
> > > > > > > > to schedule the task 20 mS from now, so make it explicit in
> > > > > > > > the code.
> > > > > > > > 
> > > > > > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > > > > > Cc: Vipul Kumar Samar <vipulkumar.samar@st.com>
> > > > > > > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > > > > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > > > > > ---
> > > > > > > > 
> > > > > > > >  drivers/input/touchscreen/stmpe-ts.c | 2 +-
> > > > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > > 
> > > > > > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > > > > 
> > > > > > Applied both, thank you.
> > > > > 
> > > > > Thank you! Shall I submit them for -stable as well please ?
> > > > 
> > > > Please.
> > > 
> > > Hi,
> > > 
> > > these patches still didn't make it for Linus's tree. I cannot submit
> > > to -stable unless they hit Linus's tree to my knowledge. Shall I wait
> > > some more please ?
> > 
> > They are in -next. I guess I could get them in 4.1...
> 
> In case it's not much of a hassle for everyone involved, it would be nice.
> Otherwise, I will just wait for 4.2 merge window to open and submit for
> stable after that. Just let me know what you prefer and I will do so.

I sent pull request to Linus, so let's see.

Thanks.

-- 
Dmitry

Re: [PATCH 1/2] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Marek Vasut]

On Saturday, May 23, 2015 at 01:30:48 AM, Dmitry Torokhov wrote:

[...]

> > In case it's not much of a hassle for everyone involved, it would be
> > nice. Otherwise, I will just wait for 4.2 merge window to open and
> > submit for stable after that. Just let me know what you prefer and I
> > will do so.
> 
> I sent pull request to Linus, so let's see.

Hi!

Thank you very much !

Best regards,
Marek Vasut