From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Heiner Kallweit <heiner.kallweit@web.de>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] touchscreen: stmpe-ts: enable module autoload
Date: Thu, 21 May 2015 16:06:12 -0700 [thread overview]
Message-ID: <20150521230612.GA39517@dtor-ws> (raw)
In-Reply-To: <555E4BF8.80401@web.de>
Hi Heiner,
On Thu, May 21, 2015 at 11:19:52PM +0200, Heiner Kallweit wrote:
> Even with poper DT config the module didn't autoload.
> That's fixed by this additional alias.
>
> Tested successfully with a STMPE610-based Adafruit PITFT Plus 3.5"
> on RPI2 under Arch Linux ARM (kernel 3.18.13).
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/input/touchscreen/stmpe-ts.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index e4c3125..1940e3c 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -393,4 +393,5 @@ module_platform_driver(stmpe_ts_driver);
> MODULE_AUTHOR("Luotao Fu <l.fu@pengutronix.de>");
> MODULE_DESCRIPTION("STMPEXXX touchscreen driver");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS("spi:" STMPE_TS_NAME);
> MODULE_ALIAS("platform:" STMPE_TS_NAME);
Bit this is not an SPI driver, it is a platform driver for a MFD cell.
Why does adding SPI alias help?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-05-21 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 21:19 [PATCH] touchscreen: stmpe-ts: enable module autoload Heiner Kallweit
2015-05-21 23:06 ` Dmitry Torokhov [this message]
2015-05-22 5:34 ` Heiner Kallweit
2015-05-22 18:29 ` Dmitry Torokhov
2015-05-22 19:01 ` Heiner Kallweit
2015-05-22 20:17 ` Dmitry Torokhov
2015-05-22 21:02 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521230612.GA39517@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=heiner.kallweit@web.de \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).