From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Frank.Li@freescale.com
Cc: lznuaa@gmail.com, shawn.guo@linaro.org,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, rtc-linux@googlegroups.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/6] rtc: arm: imx: snvs: change use syscon to access register
Date: Fri, 22 May 2015 10:07:49 +0200 [thread overview]
Message-ID: <20150522080749.GI3244@piout.net> (raw)
In-Reply-To: <1432225012-20598-2-git-send-email-Frank.Li@freescale.com>
Hi,
This looks good to me, a few nits below
On 22/05/2015 at 00:16:47 +0800, Frank.Li@freescale.com wrote :
> - spin_unlock_irqrestore(&data->lock, flags);
> + regmap_update_bits(data->regmap, data->offset + SNVS_LPCR,
> + (SNVS_LPCR_LPTA_EN | SNVS_LPCR_LPWUI_EN),
That line is not properly aligned (missing one space)
[...]
> + if (of_device_is_compatible(snvs_np, "syscon")) {
> + data->regmap = syscon_node_to_regmap(snvs_np);
> + data->offset = 0x34;
> + } else {
> + pr_warning("snvs rtc: you use old dts file, please update it\n");
This should be pr_warn()
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-22 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 16:16 [PATCH v3 0/6] Change snvs rtc and poweroff to use syscon add pwrkey driver Frank.Li
2015-05-21 16:16 ` [PATCH v3 1/6] rtc: arm: imx: snvs: change use syscon to access register Frank.Li
2015-05-22 8:07 ` Alexandre Belloni [this message]
2015-05-25 5:54 ` Shawn Guo
[not found] ` <1432225012-20598-1-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-05-21 16:16 ` [PATCH v3 2/6] Document: dt: fsl: snvs: change support syscon Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-05-21 16:16 ` [PATCH v3 3/6] arm: dts: imx: update snvs to use syscon access register Frank.Li
2015-05-21 16:16 ` [PATCH v3 4/6] input: keyboard: imx: add snvs power key driver Frank.Li
2015-05-21 16:16 ` [PATCH v3 5/6] document: devicetree: input: imx: i.mx snvs power device tree bindings Frank.Li
2015-05-21 16:16 ` [PATCH v3 6/6] arm: dts: imx6sx: enable snvs power key Frank.Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522080749.GI3244@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=Frank.Li@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lznuaa@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).