From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: sentelic - use "static inline" instead of "inline"
Date: Fri, 22 May 2015 09:57:05 -0700 [thread overview]
Message-ID: <20150522165705.GB40101@dtor-ws> (raw)
In-Reply-To: <1430072122-9902-1-git-send-email-raj.khem@gmail.com>
On Sun, Apr 26, 2015 at 06:15:22PM +0000, Khem Raj wrote:
> gcc-5 defaults to gnu11 which used c99 inline semantics
> in c99 'inline' is not externally visible unlike gnu89, therefore
> we use 'static inline' which has same semantics between gnu89 and c99
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied, thank you.
> ---
> drivers/input/mouse/sentelic.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/mouse/sentelic.h b/drivers/input/mouse/sentelic.h
> index aa697ec..42df9e3 100644
> --- a/drivers/input/mouse/sentelic.h
> +++ b/drivers/input/mouse/sentelic.h
> @@ -123,11 +123,11 @@ struct fsp_data {
> extern int fsp_detect(struct psmouse *psmouse, bool set_properties);
> extern int fsp_init(struct psmouse *psmouse);
> #else
> -inline int fsp_detect(struct psmouse *psmouse, bool set_properties)
> +static inline int fsp_detect(struct psmouse *psmouse, bool set_properties)
> {
> return -ENOSYS;
> }
> -inline int fsp_init(struct psmouse *psmouse)
> +static inline int fsp_init(struct psmouse *psmouse)
> {
> return -ENOSYS;
> }
> --
> 2.1.4
>
--
Dmitry
prev parent reply other threads:[~2015-05-22 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 18:15 [PATCH] Input: sentelic - use "static inline" instead of "inline" Khem Raj
2015-05-22 16:57 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522165705.GB40101@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox