From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH] Input: stmpe-ts - enforce device tree only mode Date: Sat, 23 May 2015 18:38:54 +0200 Message-ID: <201505231838.54349.marex@denx.de> References: <20150522225832.GA19831@dtor-ws> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-out.m-online.net ([212.18.0.10]:52614 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753235AbbEWQjK (ORCPT ); Sat, 23 May 2015 12:39:10 -0400 In-Reply-To: <20150522225832.GA19831@dtor-ws> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Samuel Ortiz , Lee Jones , Heiner Kallweit , Linus Walleij , linux-kernel@vger.kernel.org On Saturday, May 23, 2015 at 12:58:32 AM, Dmitry Torokhov wrote: > The STMPE MFD is only used with device tree configured systems (and STMPE > MFD core depends on OF), so force the configuration to come from device > tree only. > > Signed-off-by: Dmitry Torokhov > --- Hi! [...] > @@ -351,14 +336,13 @@ static int stmpe_input_probe(struct platform_device > *pdev) idev->name = STMPE_TS_NAME; > idev->phys = STMPE_TS_NAME"/input0"; > idev->id.bustype = BUS_I2C; > - idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS); > - idev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH); > > idev->open = stmpe_ts_open; > idev->close = stmpe_ts_close; > > input_set_drvdata(idev, ts); > > + input_set_capability(idev, EV_KEY, BTN_TOUCH); Isn't this part of the patch dropping the EV_ABS evbit ? > input_set_abs_params(idev, ABS_X, 0, XY_MASK, 0, 0); > input_set_abs_params(idev, ABS_Y, 0, XY_MASK, 0, 0); > input_set_abs_params(idev, ABS_PRESSURE, 0x0, 0xff, 0, 0); [...] Best regards, Marek Vasut