From: Shawn Guo <shawn.guo@linaro.org>
To: Frank.Li@freescale.com
Cc: lznuaa@gmail.com, dmitry.torokhov@gmail.com, robh+dt@kernel.org,
alexandre.belloni@free-electrons.com, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, rtc-linux@googlegroups.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/6] arm: dts: imx: update snvs to use syscon access register
Date: Mon, 25 May 2015 14:39:14 +0800 [thread overview]
Message-ID: <20150525063913.GF3264@dragon> (raw)
In-Reply-To: <1432305399-30571-4-git-send-email-Frank.Li@freescale.com>
On Fri, May 22, 2015 at 10:36:36PM +0800, Frank.Li@freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
>
> snvs is MFP device. Change dts to use syscon to allocate register resource.
> snvs power off also switch to common syscon-poweroff
>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
> ---
> arch/arm/boot/dts/imx6qdl.dtsi | 19 +++++++++----------
> arch/arm/boot/dts/imx6sl.dtsi | 19 +++++++++----------
> arch/arm/boot/dts/imx6sx.dtsi | 17 ++++++++---------
> arch/arm/boot/dts/vfxxx.dtsi | 9 +++------
> 4 files changed, 29 insertions(+), 35 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 0482a66..4f3f5f4 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -686,22 +686,21 @@
> fsl,anatop = <&anatop>;
> };
>
> - snvs@020cc000 {
> - compatible = "fsl,sec-v4.0-mon", "simple-bus";
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges = <0 0x020cc000 0x4000>;
> + snvs:snvs@020cc000 {
There should be a space between label and node.
> + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd";
One space is enough in between.
> + reg = <0x020cc000 0x4000>;
>
> - snvs_rtc: snvs-rtc-lp@34 {
> + snvs_rtc: snvs-rtc-lp {
> compatible = "fsl,sec-v4.0-mon-rtc-lp";
> - reg = <0x34 0x58>;
I think rtc node should have a similar property list like snvs-poweroff,
i.e. regmap and offset.
Shawn
> interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>,
> <0 20 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> - snvs_poweroff: snvs-poweroff@38 {
> - compatible = "fsl,sec-v4.0-poweroff";
> - reg = <0x38 0x4>;
> + snvs_poweroff: snvs-poweroff {
> + compatible = "syscon-poweroff";
> + regmap = <&snvs>;
> + offset = <0x38>;
> + mask = <0x60>;
> status = "disabled";
> };
> };
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index a78e715..2de6d46 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -563,22 +563,21 @@
> fsl,anatop = <&anatop>;
> };
>
> - snvs@020cc000 {
> - compatible = "fsl,sec-v4.0-mon", "simple-bus";
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges = <0 0x020cc000 0x4000>;
> + snvs:snvs@020cc000 {
> + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd";
> + reg = <0x020cc000 0x4000>;
>
> - snvs_rtc: snvs-rtc-lp@34 {
> + snvs_rtc: snvs-rtc-lp {
> compatible = "fsl,sec-v4.0-mon-rtc-lp";
> - reg = <0x34 0x58>;
> interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>,
> <0 20 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> - snvs_poweroff: snvs-poweroff@38 {
> - compatible = "fsl,sec-v4.0-poweroff";
> - reg = <0x38 0x4>;
> + snvs_poweroff: snvs-poweroff {
> + compatible = "syscon-poweroff";
> + regmap = <&snvs>;
> + offset = <0x38>;
> + mask = <0x60>;
> status = "disabled";
> };
> };
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 708175d..3cb3b5b 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -662,20 +662,19 @@
> };
>
> snvs: snvs@020cc000 {
> - compatible = "fsl,sec-v4.0-mon", "simple-bus";
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges = <0 0x020cc000 0x4000>;
> + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd";
> + reg = <0x020cc000 0x4000>;
>
> - snvs_rtc: snvs-rtc-lp@34 {
> + snvs_rtc: snvs-rtc-lp {
> compatible = "fsl,sec-v4.0-mon-rtc-lp";
> - reg = <0x34 0x58>;
> interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> - snvs_poweroff: snvs-poweroff@38 {
> - compatible = "fsl,sec-v4.0-poweroff";
> - reg = <0x38 0x4>;
> + snvs_poweroff: snvs-poweroff {
> + compatible = "syscon-poweroff";
> + regmap = <&snvs>;
> + offset = <0x38>;
> + mask = <0x60>;
> status = "disabled";
> };
> };
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 4aa3351..fccfc01 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -404,14 +404,11 @@
> };
>
> snvs0: snvs@400a7000 {
> - compatible = "fsl,sec-v4.0-mon", "simple-bus";
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges = <0 0x400a7000 0x2000>;
> + compatible = "fsl,sec-v4.0-mon", "syscon", "simple-mfd";
> + reg = <0x400a7000 0x2000>;
>
> - snvsrtc: snvs-rtc-lp@34 {
> + snvsrtc: snvs-rtc-lp {
> compatible = "fsl,sec-v4.0-mon-rtc-lp";
> - reg = <0x34 0x58>;
> interrupts = <100 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_SNVS>;
> clock-names = "snvs-rtc";
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-05-25 6:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 14:36 [PATCH v4 0/6] Change snvs rtc and poweroff to use syscon add pwrkey driver Frank.Li
2015-05-22 14:36 ` [PATCH v4 1/6] rtc: arm: imx: snvs: change use syscon to access register Frank.Li
2015-05-25 6:18 ` Shawn Guo
2015-05-25 6:44 ` Shawn Guo
2015-05-22 14:36 ` [PATCH v4 2/6] Document: dt: fsl: snvs: change support syscon Frank.Li
2015-05-25 6:26 ` Shawn Guo
2015-05-22 14:36 ` [PATCH v4 3/6] arm: dts: imx: update snvs to use syscon access register Frank.Li
2015-05-25 6:39 ` Shawn Guo [this message]
2015-05-22 14:36 ` [PATCH v4 4/6] input: keyboard: imx: add snvs power key driver Frank.Li
2015-05-25 7:35 ` Shawn Guo
2015-05-22 14:36 ` [PATCH v4 5/6] document: devicetree: input: imx: i.mx snvs power device tree bindings Frank.Li
[not found] ` <1432305399-30571-1-git-send-email-Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-05-22 14:36 ` [PATCH v4 6/6] arm: dts: imx6sx: enable snvs power key Frank.Li-KZfg59tc24xl57MIdRCFDg
2015-05-25 7:39 ` Shawn Guo
2015-05-25 6:47 ` [PATCH v4 0/6] Change snvs rtc and poweroff to use syscon add pwrkey driver Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525063913.GF3264@dragon \
--to=shawn.guo@linaro.org \
--cc=Frank.Li@freescale.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lznuaa@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).