From: Michael Welling <mwelling-EkmVulN54Sk@public.gmane.org>
To: "Cooper Jr., Franklin" <fcooper-l0cyMroinI0@public.gmane.org>
Cc: "Balbi, Felipe" <balbi-l0cyMroinI0@public.gmane.org>,
"dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"R, Vignesh" <vigneshr-l0cyMroinI0@public.gmane.org>,
"Griffis, Brad" <bgriffis-l0cyMroinI0@public.gmane.org>,
"jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org"
<wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
"linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"GWilson-+8BKOH/0X5NWk0Htik3J/w@public.gmane.org"
<GWilson-+8BKOH/0X5NWk0Htik3J/w@public.gmane.org>,
"linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: AM335x touchscreen issues
Date: Tue, 26 May 2015 16:28:51 -0500 [thread overview]
Message-ID: <20150526212851.GA12224@deathray> (raw)
In-Reply-To: <8F29D6B095ED194EA1980491A5E029710C89C445-CXzTdvP5/9qIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
On Tue, May 26, 2015 at 09:15:53PM +0000, Cooper Jr., Franklin wrote:
> Michael,
>
> Can you send me the output of ts_test_raw after you done a 5 or so touch down and touch up events? In the output let me know at which point in the log that the issue you observed has occurred. Please try to avoid moving your finger since I want to see the full output of that program but I'm not interested any unnecessary pen down events.
>
Oddly the repeated pen up and down events do not occur when running ts_print_raw:
root@som3517-som200:~# ts_print_raw
1418169393.147827: 1648 2075 206
1418169393.229976: 1725 1983 240
1418169393.312154: 1731 1980 240
1418169393.394333: 1706 2043 239
1418169393.476523: 1703 2028 241
1418169393.558708: 1714 2041 240
1418169393.640888: 1704 2041 240
1418169393.721556: 0 0 0
1418169395.283096: 2889 2512 192
1418169395.365236: 2947 2486 210
1418169395.447413: 2949 2470 211
1418169395.529606: 2943 2497 211
1418169395.611759: 2922 2506 211
1418169395.693935: 2866 2474 213
1418169395.776135: 2858 2481 214
1418169395.858305: 2861 2451 213
1418169395.938972: 0 0 0
1418169397.482867: 1083 1981 236
1418169397.565026: 1157 1832 254
1418169397.647217: 1161 1856 256
1418169397.729412: 1158 1883 255
1418169397.811583: 1159 1841 255
1418169397.893760: 1159 1864 256
1418169397.975947: 1158 1893 256
1418169398.056605: 0 0 0
1418169399.690290: 2299 2372 178
1418169399.772432: 2388 2160 221
1418169399.854611: 2391 2190 223
1418169399.936802: 2379 2207 223
1418169400.018966: 2389 2184 223
1418169400.101146: 2383 2208 224
1418169400.183338: 2381 2203 223
1418169400.264012: 0 0 0
1418169402.073266: 1230 2381 212
1418169402.155413: 1301 2097 247
1418169402.237590: 1313 2077 248
1418169402.319772: 1307 2126 248
1418169402.401948: 1304 2096 248
1418169402.484127: 4078 2155 58
1418169402.564801: 0 0 0
Here is what the output of ts_test looks like without even touching the screen:
root@som3517-som200:~# ts_test
1418169549.722957: 816 17 58
1418169549.803604: 816 17 0
1418169549.817757: 816 25 58
1418169549.898411: 816 25 0
1418169549.912828: 816 41 59
1418169549.993463: 816 41 0
1418169550.007771: 816 28 58
1418169550.088404: 816 28 0
1418169550.102828: 816 33 58
1418169550.183486: 816 33 0
1418169550.197767: 816 42 59
1418169550.278401: 816 42 0
1418169550.292970: 816 23 58
1418169550.373604: 816 23 0
1418169550.387773: 816 28 58
1418169550.468404: 816 28 0
1418169550.482955: 816 32 59
1418169550.563600: 816 32 0
1418169550.577773: 816 25 58
1418169550.658406: 816 25 0
1418169550.672827: 816 35 59
1418169550.753464: 816 35 0
1418169550.767761: 816 42 59
1418169550.848407: 816 42 0
1418169550.862826: 816 41 59
1418169550.943462: 816 41 0
1418169550.958013: 816 37 59
1418169551.038655: 816 37 0
1418169551.052824: 816 41 59
1418169551.133475: 816 41 0
1418169551.147774: 816 28 58
1418169551.228406: 816 28 0
.
.
> I recently encountered several touchscreen problems that I am working on submitting to mainline. Below are the variety of issues I discovered and fixed but its currently based on 3.14 kernel.
>
> 1. The x and y location right before a penup event is usually incorrect. Visibly the causes the cursor to jump right before a touchup. So I implemented a way to ignore that incorrect event.
> 2. I discovered that for some reason a series of touch up events are sent back to back. So I added something to ignore consecutive pen up events.
> 3. Sometimes a pen down event is reported with a pressure of 0. I noticed applications like ts_lib looked at the pressure and thought a pressure of 0 means a finger was lifted. So I added a patch that ignored 0 pressure pen down events. This prevented premature touchups.
> 4. I added debouncing. Essentially the driver didn't report any touch events for a user specified number of ms after a pen up occured. It was noticed especially during touchscreen calibration that after a person lifted their finger after touching the screen a combination of pen up and pen down events were incorrectly detected.
>
> Most likely a combination of 2-4 is your problem. I think the udelay acted like an unintentional debounce which is probably why it wasn't discovered sooner.
> > >
> > > --
> > > balbi
> >
>
next prev parent reply other threads:[~2015-05-26 21:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 18:11 AM335x touchscreen issues Michael Welling
2015-05-26 18:37 ` Felipe Balbi
[not found] ` <20150526183713.GU26599-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-05-26 20:53 ` Michael Welling
2015-05-26 21:15 ` Cooper Jr., Franklin
[not found] ` <8F29D6B095ED194EA1980491A5E029710C89C445-CXzTdvP5/9qIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2015-05-26 21:28 ` Michael Welling [this message]
2015-05-26 21:34 ` Cooper Jr., Franklin
[not found] ` <8F29D6B095ED194EA1980491A5E029710C89C4E0-CXzTdvP5/9qIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2015-05-26 21:36 ` Griffis, Brad
[not found] ` <912A29987EAE174BA6CF187D7CDFA9CE270A8C43-YmePFLaaepqIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2015-05-26 21:50 ` Michael Welling
2015-05-26 22:25 ` Griffis, Brad
[not found] ` <912A29987EAE174BA6CF187D7CDFA9CE270A8D48-YmePFLaaepqIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2015-05-26 22:46 ` Michael Welling
2015-05-26 22:31 ` Cooper Jr., Franklin
[not found] ` <8F29D6B095ED194EA1980491A5E029710C89C70D-CXzTdvP5/9qIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2015-05-26 23:06 ` Michael Welling
2015-05-26 23:37 ` Cooper Jr., Franklin
2015-05-27 4:06 ` Vignesh R
2015-05-27 17:29 ` Michael Welling
2015-05-26 21:41 ` Michael Welling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526212851.GA12224@deathray \
--to=mwelling-ekmvuln54sk@public.gmane.org \
--cc=GWilson-+8BKOH/0X5NWk0Htik3J/w@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=bgriffis-l0cyMroinI0@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=fcooper-l0cyMroinI0@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vigneshr-l0cyMroinI0@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).