* [PATCH] Input:mouse:synaptics_i2c - Use bool function return value
@ 2015-05-25 17:33 Shailendra Verma
2015-05-26 21:44 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Shailendra Verma @ 2015-05-25 17:33 UTC (permalink / raw)
To: Dmitry Torokhov, Jingoo Han, linux-input; +Cc: linux-kernel, Shailendra Verma
The function synaptics_i2c_get_input() has bool return type.
So use bool value flase instead of 0 to return.
Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
drivers/input/mouse/synaptics_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c
index 2c87a93..ffceedc 100644
--- a/drivers/input/mouse/synaptics_i2c.c
+++ b/drivers/input/mouse/synaptics_i2c.c
@@ -342,7 +342,7 @@ static bool synaptics_i2c_get_input(struct synaptics_i2c *touch)
/* Deal with spontaneous resets and errors */
if (synaptics_i2c_check_error(touch->client))
- return 0;
+ return false;
/* Get Gesture Bit */
data = synaptics_i2c_reg_get(touch->client, DATA_REG0);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input:mouse:synaptics_i2c - Use bool function return value
2015-05-25 17:33 [PATCH] Input:mouse:synaptics_i2c - Use bool function return value Shailendra Verma
@ 2015-05-26 21:44 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-05-26 21:44 UTC (permalink / raw)
To: Shailendra Verma; +Cc: Jingoo Han, linux-input, linux-kernel
On Mon, May 25, 2015 at 11:03:04PM +0530, Shailendra Verma wrote:
> The function synaptics_i2c_get_input() has bool return type.
> So use bool value flase instead of 0 to return.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
Folded all 3 patches together and applied.
Thank you.
> ---
> drivers/input/mouse/synaptics_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c
> index 2c87a93..ffceedc 100644
> --- a/drivers/input/mouse/synaptics_i2c.c
> +++ b/drivers/input/mouse/synaptics_i2c.c
> @@ -342,7 +342,7 @@ static bool synaptics_i2c_get_input(struct synaptics_i2c *touch)
>
> /* Deal with spontaneous resets and errors */
> if (synaptics_i2c_check_error(touch->client))
> - return 0;
> + return false;
>
> /* Get Gesture Bit */
> data = synaptics_i2c_reg_get(touch->client, DATA_REG0);
> --
> 1.7.9.5
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-26 21:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-25 17:33 [PATCH] Input:mouse:synaptics_i2c - Use bool function return value Shailendra Verma
2015-05-26 21:44 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).