linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	rpurdie@rpsys.net,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs
Date: Tue, 9 Jun 2015 09:50:52 -0700	[thread overview]
Message-ID: <20150609165052.GE6338@dtor-ws> (raw)
In-Reply-To: <20150609132734.GA3132@type>

On Tue, Jun 09, 2015 at 03:27:34PM +0200, Samuel Thibault wrote:
> Samuel Thibault, le Tue 09 Jun 2015 15:19:55 +0200, a écrit :
> > > +	[LED_NUML]	= { "num-lock", VT_TRIGGER("kbd-numlock") },
> > > +	[LED_CAPSL]	= { "caps-lock", VT_TRIGGER("kbd-capslock") },
> > > +	[LED_SCROLLL]	= { "scroll-lock", VT_TRIGGER("kbd-scrollock") },
> > 
> > I'd tend to think we'd want to harmonize the user-visible LED names and
> > kbd trigger names,
> 
> And perhaps fix that odd-looking "scrollock"?

If you are talking about LED_SCROLLL then iut is a part of published
userspace API and we can only add an alias. If we want to do that I'd do
it in a separate patch.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-06-09 16:50 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 21:43 [PATCH 0/3] Switch input leds over to standard LED class devices Dmitry Torokhov
2015-06-08 21:43 ` [PATCH 1/3] Input: export LEDs as class devices in sysfs Dmitry Torokhov
2015-06-09 13:19   ` Samuel Thibault
2015-06-09 13:27     ` Samuel Thibault
2015-06-09 16:50       ` Dmitry Torokhov [this message]
2015-06-09 17:16         ` Samuel Thibault
2015-06-09 16:49     ` Dmitry Torokhov
2015-06-09 17:22       ` Samuel Thibault
2015-06-09 17:32         ` Dmitry Torokhov
2015-06-10  6:34       ` Pavel Machek
2015-06-09 17:42   ` [PATCH v2 " Dmitry Torokhov
2015-06-10  0:32     ` Samuel Thibault
2015-06-10  1:24       ` Dmitry Torokhov
2015-06-11 17:51         ` Pavel Machek
2015-06-15 10:03         ` Pavel Machek
2015-06-15 10:51           ` Pali Rohár
2015-07-21 11:14     ` Vlastimil Babka
2015-07-21 17:01       ` Dmitry Torokhov
2015-07-21 21:08         ` Pavel Machek
2015-07-22 13:12           ` Vlastimil Babka
2015-07-22 18:55             ` Jiri Kosina
2015-07-23  5:19               ` Vlastimil Babka
2015-07-23  5:42                 ` Jiri Kosina
2015-07-22 14:41         ` Vlastimil Babka
2015-07-22 19:49           ` Jiri Kosina
2015-07-22 21:47             ` Pavel Machek
2015-07-22 21:50               ` Jiri Kosina
2015-07-22 21:49             ` Dmitry Torokhov
2015-07-22 22:01               ` Jiri Kosina
2015-06-08 21:43 ` [PATCH 2/3] tty/vt/keyboard: define LED triggers for VT LED states Dmitry Torokhov
2015-06-08 21:43 ` [PATCH 3/3] tty/vt/keyboard: define LED triggers for VT keyboard lock states Dmitry Torokhov
2015-06-08 22:58 ` [PATCH 0/3] Switch input leds over to standard LED class devices Bastien Nocera
2015-06-08 23:16   ` Dmitry Torokhov
2015-06-09 10:54 ` Pavel Machek
2015-06-09 11:12   ` Pavel Machek
2015-06-09 11:22     ` Pali Rohár
2015-06-09 11:28       ` Pavel Machek
2015-06-09 12:22       ` Samuel Thibault
2015-06-09 11:26     ` Pavel Machek
2015-06-09 16:40       ` Dmitry Torokhov
2015-06-09 12:20   ` Samuel Thibault
2015-06-09 16:18   ` Pavel Machek
2015-06-09 16:32     ` Dmitry Torokhov
2015-06-09 16:37   ` Dmitry Torokhov
2015-06-09 13:42 ` Samuel Thibault
2015-06-09 13:50   ` Pali Rohár
2015-06-09 14:05     ` Samuel Thibault
     [not found] ` <20090205113908.GA14224@const.inria.fr>
2015-06-09 14:17   ` caps lock led does not show up Samuel Thibault
2015-06-09 16:03     ` Bug#514464: " Anton Zinoviev
2015-06-11  8:08       ` Samuel Thibault
2015-06-11 14:28         ` Samuel Thibault
2015-06-11 15:37           ` Samuel Thibault
2015-06-25 15:41             ` Samuel Thibault
2015-07-02 16:39               ` Anton Zinoviev
2015-07-02 16:50                 ` Samuel Thibault
2015-08-31  8:33                 ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609165052.GE6338@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).