From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs Date: Tue, 9 Jun 2015 09:50:52 -0700 Message-ID: <20150609165052.GE6338@dtor-ws> References: <1433799790-31873-1-git-send-email-dmitry.torokhov@gmail.com> <1433799790-31873-2-git-send-email-dmitry.torokhov@gmail.com> <20150609131955.GA3045@type> <20150609132734.GA3132@type> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f196.google.com ([209.85.223.196]:34546 "EHLO mail-ie0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbbFIQu4 (ORCPT ); Tue, 9 Jun 2015 12:50:56 -0400 Content-Disposition: inline In-Reply-To: <20150609132734.GA3132@type> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Samuel Thibault , Pavel Machek , Pali =?iso-8859-1?Q?Roh=E1r?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, rpurdie@rpsys.net, Greg Kroah-Hartman On Tue, Jun 09, 2015 at 03:27:34PM +0200, Samuel Thibault wrote: > Samuel Thibault, le Tue 09 Jun 2015 15:19:55 +0200, a =E9crit : > > > + [LED_NUML] =3D { "num-lock", VT_TRIGGER("kbd-numlock") }, > > > + [LED_CAPSL] =3D { "caps-lock", VT_TRIGGER("kbd-capslock") }, > > > + [LED_SCROLLL] =3D { "scroll-lock", VT_TRIGGER("kbd-scrollock") = }, > >=20 > > I'd tend to think we'd want to harmonize the user-visible LED names= and > > kbd trigger names, >=20 > And perhaps fix that odd-looking "scrollock"? If you are talking about LED_SCROLLL then iut is a part of published userspace API and we can only add an alias. If we want to do that I'd d= o it in a separate patch. Thanks. --=20 Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html