* [PATCH] Input: goodix - do not explicitly set evbits in input device
@ 2015-06-09 18:52 Dmitry Torokhov
2015-06-10 10:18 ` Bastien Nocera
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2015-06-09 18:52 UTC (permalink / raw)
To: Bastien Nocera
Cc: Irina Tirdea, Benjamin Tissoires, linux-input, linux-kernel
input_mt_init_slots() will do that for us.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/goodix.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 73ade35..b4d12e2 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -301,10 +301,6 @@ static int goodix_request_input_dev(struct goodix_ts_data *ts, u16 version,
return -ENOMEM;
}
- ts->input_dev->evbit[0] = BIT_MASK(EV_SYN) |
- BIT_MASK(EV_KEY) |
- BIT_MASK(EV_ABS);
-
input_set_abs_params(ts->input_dev, ABS_MT_POSITION_X,
0, ts->abs_x_max, 0, 0);
input_set_abs_params(ts->input_dev, ABS_MT_POSITION_Y,
--
2.2.0.rc0.207.ga3a616c
--
Dmitry
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: goodix - do not explicitly set evbits in input device
2015-06-09 18:52 [PATCH] Input: goodix - do not explicitly set evbits in input device Dmitry Torokhov
@ 2015-06-10 10:18 ` Bastien Nocera
2015-06-10 14:39 ` Benjamin Tissoires
0 siblings, 1 reply; 4+ messages in thread
From: Bastien Nocera @ 2015-06-10 10:18 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Irina Tirdea, Benjamin Tissoires, linux-input, linux-kernel
On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote:
> input_mt_init_slots() will do that for us.
I'm guessing you know what you're doing here, but I couldn't find where
the EV_SYN bit would have been set in the input_mt_init_slots() call
chain.
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/touchscreen/goodix.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index 73ade35..b4d12e2 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -301,10 +301,6 @@ static int goodix_request_input_dev(struct
> goodix_ts_data *ts, u16 version,
> return -ENOMEM;
> }
>
> - ts->input_dev->evbit[0] = BIT_MASK(EV_SYN) |
> - BIT_MASK(EV_KEY) |
> - BIT_MASK(EV_ABS);
> -
> input_set_abs_params(ts->input_dev, ABS_MT_POSITION_X,
> 0, ts->abs_x_max, 0, 0);
> input_set_abs_params(ts->input_dev, ABS_MT_POSITION_Y,
> --
> 2.2.0.rc0.207.ga3a616c
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: goodix - do not explicitly set evbits in input device
2015-06-10 10:18 ` Bastien Nocera
@ 2015-06-10 14:39 ` Benjamin Tissoires
2015-06-10 15:08 ` Bastien Nocera
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Tissoires @ 2015-06-10 14:39 UTC (permalink / raw)
To: Bastien Nocera; +Cc: Dmitry Torokhov, Irina Tirdea, linux-input, linux-kernel
On Jun 10 2015 or thereabouts, Bastien Nocera wrote:
> On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote:
> > input_mt_init_slots() will do that for us.
>
> I'm guessing you know what you're doing here, but I couldn't find where
> the EV_SYN bit would have been set in the input_mt_init_slots() call
> chain.
input_register_device() sets EV_SYN bit for us (it is a mandatory field
for input).
>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> > drivers/input/touchscreen/goodix.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/goodix.c
> > b/drivers/input/touchscreen/goodix.c
> > index 73ade35..b4d12e2 100644
> > --- a/drivers/input/touchscreen/goodix.c
> > +++ b/drivers/input/touchscreen/goodix.c
> > @@ -301,10 +301,6 @@ static int goodix_request_input_dev(struct
> > goodix_ts_data *ts, u16 version,
> > return -ENOMEM;
> > }
> >
> > - ts->input_dev->evbit[0] = BIT_MASK(EV_SYN) |
> > - BIT_MASK(EV_KEY) |
> > - BIT_MASK(EV_ABS);
> > -
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> > input_set_abs_params(ts->input_dev, ABS_MT_POSITION_X,
> > 0, ts->abs_x_max, 0, 0);
> > input_set_abs_params(ts->input_dev, ABS_MT_POSITION_Y,
> > --
> > 2.2.0.rc0.207.ga3a616c
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: goodix - do not explicitly set evbits in input device
2015-06-10 14:39 ` Benjamin Tissoires
@ 2015-06-10 15:08 ` Bastien Nocera
0 siblings, 0 replies; 4+ messages in thread
From: Bastien Nocera @ 2015-06-10 15:08 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Dmitry Torokhov, Irina Tirdea, linux-input, linux-kernel
On Wed, 2015-06-10 at 10:39 -0400, Benjamin Tissoires wrote:
> On Jun 10 2015 or thereabouts, Bastien Nocera wrote:
> > On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote:
> > > input_mt_init_slots() will do that for us.
> >
> > I'm guessing you know what you're doing here, but I couldn't find
> > where
> > the EV_SYN bit would have been set in the input_mt_init_slots()
> > call
> > chain.
>
> input_register_device() sets EV_SYN bit for us (it is a mandatory
> field
> for input).
<snip>
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
OK, thanks for the explanation.
Acked-by: Bastien Nocera <hadess@hadess.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-10 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-09 18:52 [PATCH] Input: goodix - do not explicitly set evbits in input device Dmitry Torokhov
2015-06-10 10:18 ` Bastien Nocera
2015-06-10 14:39 ` Benjamin Tissoires
2015-06-10 15:08 ` Bastien Nocera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).