From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [input:next 1215/1216] drivers/tty/vt/keyboard.c:994:2: warning: (near initialization for 'kbd_led_triggers[0].trigger')
Date: Wed, 17 Jun 2015 00:01:22 +0200 [thread overview]
Message-ID: <20150616220122.GV2965@type.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <201506170453.xHm7stex%fengguang.wu@intel.com>
kbuild test robot, le Wed 17 Jun 2015 04:02:55 +0800, a écrit :
> drivers/tty/vt/keyboard.c:975:20: error: 'struct led_classdev' has no member named 'trigger'
> container_of(cdev->trigger, struct kbd_led_trigger, trigger);
Right, it doesn't have it when CONFIG_LEDS_TRIGGERS is not defined.
So the condition in keyboard.c should rather be
IS_ENABLED(CONFIG_INPUT_LEDS) && IS_ENABLED(CONFIG_LEDS_TRIGGERS).
Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-16 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 20:02 [input:next 1215/1216] drivers/tty/vt/keyboard.c:994:2: warning: (near initialization for 'kbd_led_triggers[0].trigger') kbuild test robot
2015-06-16 22:01 ` Samuel Thibault [this message]
2015-06-16 22:03 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616220122.GV2965@type.youpi.perso.aquilenet.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).