From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: x86@kernel.org, Borislav Petkov <bp@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
John Stultz <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
Huang Rui <ray.huang@amd.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 11/17] drivers/input/gameport: Replace rdtscl() with native_read_tsc()
Date: Tue, 16 Jun 2015 16:04:25 -0700 [thread overview]
Message-ID: <20150616230425.GD17610@dtor-ws> (raw)
In-Reply-To: <1937af4905bc041d07d05bc51bca983a60df2c6c.1434152603.git.luto@kernel.org>
On Fri, Jun 12, 2015 at 04:44:51PM -0700, Andy Lutomirski wrote:
> It's unclear to me why this code exists in the first place.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/gameport/gameport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/gameport/gameport.c b/drivers/input/gameport/gameport.c
> index e853a2134680..abc0cb22e750 100644
> --- a/drivers/input/gameport/gameport.c
> +++ b/drivers/input/gameport/gameport.c
> @@ -149,9 +149,9 @@ static int old_gameport_measure_speed(struct gameport *gameport)
>
> for(i = 0; i < 50; i++) {
> local_irq_save(flags);
> - rdtscl(t1);
> + t1 = native_read_tsc();
> for (t = 0; t < 50; t++) gameport_read(gameport);
> - rdtscl(t2);
> + t2 = native_read_tsc();
> local_irq_restore(flags);
> udelay(i * 10);
> if (t2 - t1 < tx) tx = t2 - t1;
> --
> 2.4.2
>
--
Dmitry
prev parent reply other threads:[~2015-06-16 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1434152603.git.luto@kernel.org>
2015-06-12 23:44 ` [PATCH v2 10/17] input/joystick/analog: Switch from rdtscl() to native_read_tsc() Andy Lutomirski
2015-06-16 23:03 ` Dmitry Torokhov
2015-06-16 23:09 ` Andy Lutomirski
2015-06-16 23:15 ` Dmitry Torokhov
2015-06-12 23:44 ` [PATCH v2 11/17] drivers/input/gameport: Replace rdtscl() with native_read_tsc() Andy Lutomirski
2015-06-16 23:04 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616230425.GD17610@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bp@suse.de \
--cc=dvlasenk@redhat.com \
--cc=john.stultz@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=ray.huang@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).