linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-input@vger.kernel.org, kernel@pengutronix.de,
	Alexandre Courbot <acourbot@nvidia.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] input: improve usage of gpiod API
Date: Tue, 16 Jun 2015 17:06:08 -0700	[thread overview]
Message-ID: <20150617000608.GF17610@dtor-ws> (raw)
In-Reply-To: <20150615203847.GC19996@pengutronix.de>

On Mon, Jun 15, 2015 at 10:38:47PM +0200, Uwe Kleine-König wrote:
> Hello Dmitry,
> 
> On Wed, Feb 18, 2015 at 11:47:13AM +0100, Uwe Kleine-König wrote:
> > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> > which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> > parameter that allows to specify direction and initial value for
> > output. Simplify drivers accordingly.
> > 
> > Note that in the case of the drv260x driver error checking is more
> > strict now because -ENOSYS is reported to the caller now. But this
> > should only be returned if GPIOLIB is disabled which shouldn't happen as
> > the driver depends on GPIOLIB.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  drivers/input/keyboard/clps711x-keypad.c |  7 +------
> >  drivers/input/misc/drv260x.c             | 13 ++++---------
> >  drivers/input/misc/gpio-beeper.c         |  7 +------
> >  3 files changed, 6 insertions(+), 21 deletions(-)
> are you willing to take this? I intend to make the flags parameter
> mandatory for 4.3 and so if this change doesn't make it into 4.2-rc1,
> would it be ok for you if I send it as part of the series that makes
> flags required?

Yes, I am sorry, applied now.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2015-06-17  0:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 10:47 [PATCH] input: improve usage of gpiod API Uwe Kleine-König
2015-03-06 10:54 ` Linus Walleij
2015-05-18 19:34 ` Uwe Kleine-König
2015-06-15 20:38 ` Uwe Kleine-König
2015-06-17  0:06   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150617000608.GF17610@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=broonie@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).