From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: duson <dusonlin@emc.com.tw>, "Jiri Kosina" <jkosina@suse.cz>,
"Alessio Treglia" <alessio@debian.org>,
"Jürgen Bausa" <Juergen.Bausa@online.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.com
Subject: Re: [PATCH] Input: elan_i2c - enable ELAN0600 acpi panels
Date: Mon, 22 Jun 2015 14:37:16 -0700 [thread overview]
Message-ID: <20150622213716.GE2350@dtor-ws> (raw)
In-Reply-To: <20150611201948.GE32361@mail.corp.redhat.com>
On Thu, Jun 11, 2015 at 04:19:48PM -0400, Benjamin Tissoires wrote:
> On Apr 09 2015 or thereabouts, duson wrote:
> > Hi Dmitry,
> >
> > Sorry later for reply. If touchpad is designed for Window OS,
> > the firmware will support standard HID mouse format (non-driver) and elan raw data format (with driver).
> >
> > So, if user change OS from Window to Linux, touchpad will work fine under HID format.
> >
>
> Well, Jurgen reported a ELAN0100 (04F3:0401) which is similar but does
> not work with the below patch (when adapted to match his PID).
> And like under Windows, the HID mouse report format is just not enough under
> Linux. We need to have access to the raw touches to be able to provide a
> consistent experience. So we need to get his device access to the
> proprietary raw format.
>
> I think what makes Jurgen's device unhappy is that the length of the
> report 0x5d is 27 instead of 31 (according to the report descriptors).
> But elan_i2c_i2c.c checks for the length of the report and fails (only
> suppositions).
>
> I would be happy to help here, but it looks like it is going to be
> difficult to remotely debug this and switch the whole driver into HID,
> especially given that elan_i2c_i2c uses a non-HID command to set the
> touchpad in the absolute mode.
>
> So basically, I don't know what to do for Jurgen, but we could still
> enable Alessio's touchpad (the ELAN0600, below). Jiri, Dmitry?
Yes, if the controller indeed has basic HID mode + advanced proprietary
protocol we should blacklist it in HID and let elan driver handle the
device. Devices that speak proper HID (both basic and multitouch) should
be handled by HID.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
prev parent reply other threads:[~2015-06-22 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 21:34 [PATCH] Input: elan_i2c - enable ELAN0600 acpi panels Benjamin Tissoires
2015-04-03 21:05 ` Dmitry Torokhov
2015-04-09 11:02 ` duson
2015-06-11 20:19 ` Benjamin Tissoires
2015-06-22 21:37 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622213716.GE2350@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Juergen.Bausa@online.de \
--cc=alessio@debian.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dusonlin@emc.com.tw \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).