From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Date: Wed, 1 Jul 2015 09:02:16 +0100 Message-ID: <20150701080216.GF3210@x1> References: <20150526161024.GQ11677@x1> <6ED8E3B22081A4459DAC7699F3695FB7014B22F4C4@SW-EX-MBX02.diasemi.com> <20150611085653.GG2982@x1> <6ED8E3B22081A4459DAC7699F3695FB7014B233463@SW-EX-MBX02.diasemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wi0-f180.google.com ([209.85.212.180]:33933 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753369AbbGAICW (ORCPT ); Wed, 1 Jul 2015 04:02:22 -0400 Received: by wiar9 with SMTP id r9so60410929wia.1 for ; Wed, 01 Jul 2015 01:02:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7014B233463@SW-EX-MBX02.diasemi.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Opensource [Steve Twiss]" Cc: LINUXKERNEL , Samuel Ortiz , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXWATCHDOG , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Support Opensource , Wim Van Sebroeck On Mon, 29 Jun 2015, Opensource [Steve Twiss] wrote: > On 11 June 2015 09:57, Lee Jones wrote: >=20 > > To: Opensource [Steve Twiss] > > Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > >=20 > > > > > > Steve Twiss wrote: > > > > > > +#define DA9062AA_PAGE_SHIFT 0 > > > > > > +#define DA9062AA_PAGE_MASK (0x3f << 0) > > > > > > +#define DA9062AA_WRITE_MODE_SHIFT 6 > > > > > > +#define DA9062AA_WRITE_MODE_MASK (0x01 << 6) > > > > > > > > > > Lee Jones wrote: > > > > > For 1 << X, you should use BIT(X). > > > > > > > > Steve Twiss wrote: > > > > The whole of this file is automatically generated by our hardwa= re designers > > > > I would prefer it if the register definitions and bit fields ar= e not altered [...] >=20 > [...] >=20 > > Lee Jones wrote: > > To be honest, it's probably not a blocker for acceptance, but if so= meone > > writes a patch next week to change all of the (0x01 << X) lines to > > start using the BIT() macro, I will accept it. Better to influence= d > > your guys so you are not overly inconvenienced. > > FWIW, when upstreaming code, the excuse "someone else wrote it", ha= s > > never been a good one to use on the lists. Believe me, I've > > tried. ;) >=20 > Hi Lee, >=20 > Depending on your next step .. > I can either send a patch to this now or wait until you have reviewed= the MFD > core: if there are any further comments on this, I can update the sub= mission > retrospectively. Let's start over. Please re-submit the set. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html