From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Dan Murphy <dmurphy@ti.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: drv260x/drv2665/drv2667 - Constify reg_default tables
Date: Wed, 8 Jul 2015 08:26:25 -0700 [thread overview]
Message-ID: <20150708152625.GB40116@dtor-ws> (raw)
In-Reply-To: <1436230899.10336.2.camel@ingics.com>
On Tue, Jul 07, 2015 at 09:01:39AM +0800, Axel Lin wrote:
> These reg_default tables are not modified after initialized, so make them
> const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied, thank you.
> ---
> drivers/input/misc/drv260x.c | 2 +-
> drivers/input/misc/drv2665.c | 2 +-
> drivers/input/misc/drv2667.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
> index e5d60ec..0e3af55 100644
> --- a/drivers/input/misc/drv260x.c
> +++ b/drivers/input/misc/drv260x.c
> @@ -204,7 +204,7 @@ struct drv260x_data {
> int overdrive_voltage;
> };
>
> -static struct reg_default drv260x_reg_defs[] = {
> +static const struct reg_default drv260x_reg_defs[] = {
> { DRV260X_STATUS, 0xe0 },
> { DRV260X_MODE, 0x40 },
> { DRV260X_RT_PB_IN, 0x00 },
> diff --git a/drivers/input/misc/drv2665.c b/drivers/input/misc/drv2665.c
> index 0afaa33..e9501fd 100644
> --- a/drivers/input/misc/drv2665.c
> +++ b/drivers/input/misc/drv2665.c
> @@ -74,7 +74,7 @@ static const u8 drv2665_sine_wave_form[] = {
> 0x9b, 0x9f, 0xa5, 0xad, 0xb8, 0xc4, 0xd2, 0xe0, 0xf0, 0x00,
> };
>
> -static struct reg_default drv2665_reg_defs[] = {
> +static const struct reg_default drv2665_reg_defs[] = {
> { DRV2665_STATUS, 0x02 },
> { DRV2665_CTRL_1, 0x28 },
> { DRV2665_CTRL_2, 0x40 },
> diff --git a/drivers/input/misc/drv2667.c b/drivers/input/misc/drv2667.c
> index fc0fddf..a231342 100644
> --- a/drivers/input/misc/drv2667.c
> +++ b/drivers/input/misc/drv2667.c
> @@ -116,7 +116,7 @@ struct drv2667_data {
> u32 frequency;
> };
>
> -static struct reg_default drv2667_reg_defs[] = {
> +static const struct reg_default drv2667_reg_defs[] = {
> { DRV2667_STATUS, 0x02 },
> { DRV2667_CTRL_1, 0x28 },
> { DRV2667_CTRL_2, 0x40 },
> --
> 2.1.0
>
>
>
--
Dmitry
prev parent reply other threads:[~2015-07-08 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 1:01 [PATCH] Input: drv260x/drv2665/drv2667 - Constify reg_default tables Axel Lin
2015-07-08 15:26 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708152625.GB40116@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=axel.lin@ingics.com \
--cc=dmurphy@ti.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).