linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Florian floe Echtler <floe@butterbrot.org>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Re: [PATCH resend] input: fix sur40.c dependency/build errors
Date: Fri, 10 Jul 2015 10:08:53 -0700	[thread overview]
Message-ID: <20150710170853.GC35720@dtor-ws> (raw)
In-Reply-To: <20150710170328.GB35720@dtor-ws>

On Fri, Jul 10, 2015 at 10:03:28AM -0700, Dmitry Torokhov wrote:
> On Fri, Jul 10, 2015 at 08:15:57AM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > Fix build errors due to missing Kconfig dependency.
> > 
> > drivers/built-in.o: In function `sur40_disconnect':
> > sur40.c:(.text+0x22be6e): undefined reference to `video_unregister_device'
> > sur40.c:(.text+0x22be77): undefined reference to `v4l2_device_unregister'
> > drivers/built-in.o: In function `sur40_process_video':
> > sur40.c:(.text+0x22c1d4): undefined reference to `v4l2_get_timestamp'
> > drivers/built-in.o: In function `sur40_probe':
> > sur40.c:(.text+0x22ca82): undefined reference to `v4l2_device_register'
> > sur40.c:(.text+0x22cb1a): undefined reference to `v4l2_device_unregister'
> > sur40.c:(.text+0x22cbf7): undefined reference to `video_device_release_empty'
> > sur40.c:(.text+0x22cc53): undefined reference to `__video_register_device'
> > sur40.c:(.text+0x22cc90): undefined reference to `video_unregister_device'
> > drivers/built-in.o: In function `sur40_vidioc_querycap':
> > sur40.c:(.text+0x22ccb0): undefined reference to `video_devdata'
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Applied, thank you.

Actually, Mauro, can this go through media tree for now?

> 
> > ---
> >  drivers/input/touchscreen/Kconfig |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- linux-next-20150710.orig/drivers/input/touchscreen/Kconfig
> > +++ linux-next-20150710/drivers/input/touchscreen/Kconfig
> > @@ -993,6 +993,7 @@ config TOUCHSCREEN_SUN4I
> >  config TOUCHSCREEN_SUR40
> >  	tristate "Samsung SUR40 (Surface 2.0/PixelSense) touchscreen"
> >  	depends on USB && MEDIA_USB_SUPPORT && HAS_DMA
> > +	depends on VIDEO_V4L2
> >  	select INPUT_POLLDEV
> >  	select VIDEOBUF2_DMA_SG
> >  	help
> 
> -- 
> Dmitry

-- 
Dmitry

  reply	other threads:[~2015-07-10 17:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10 15:15 [PATCH resend] input: fix sur40.c dependency/build errors Randy Dunlap
2015-07-10 17:03 ` Dmitry Torokhov
2015-07-10 17:08   ` Dmitry Torokhov [this message]
2015-10-17 17:13     ` Dmitry Torokhov
2015-10-17 18:37       ` Randy Dunlap
2015-10-18 23:27         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150710170853.GC35720@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=floe@butterbrot.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).