From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: HungNien Chen <hn.chen@weidahitech.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
charliemooney@google.com
Subject: Re: [PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset
Date: Sat, 11 Jul 2015 23:28:47 -0700 [thread overview]
Message-ID: <20150712062847.GA37026@dtor-ws> (raw)
In-Reply-To: <1436625402-4501-1-git-send-email-hn.chen@weidahitech.com>
On Sat, Jul 11, 2015 at 10:36:42PM +0800, HungNien Chen wrote:
> The original value is 200ms, it includes the loading fw & boot up to
> the main function. After that, the main function will do algorithm
> initialized and touch calibrtion about 1.1 second. The touch
> calibration will change controller freq to scan the best working freq
> and it has risk to make the i2c data error when doing fw update.
> We extend the sleep to 2500ms after the sw reset to skip this period time.
>
> Signed-off-by: HungNien Chen <hn.chen@weidahitech.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/wdt87xx_i2c.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c b/drivers/input/touchscreen/wdt87xx_i2c.c
> index b97cb4f..cfd1487 100644
> --- a/drivers/input/touchscreen/wdt87xx_i2c.c
> +++ b/drivers/input/touchscreen/wdt87xx_i2c.c
> @@ -157,6 +157,7 @@
> /* Controller requires minimum 300us between commands */
> #define WDT_COMMAND_DELAY_MS 2
> #define WDT_FLASH_WRITE_DELAY_MS 4
> +#define WDT_FW_RESET_TIME 2500
>
> struct wdt87xx_sys_param {
> u16 fw_id;
> @@ -413,7 +414,7 @@ static int wdt87xx_sw_reset(struct i2c_client *client)
> }
>
> /* Wait the device to be ready */
> - msleep(200);
> + msleep(WDT_FW_RESET_TIME);
>
> return 0;
> }
> --
> 1.9.1
>
--
Dmitry
next prev parent reply other threads:[~2015-07-12 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 14:36 [PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset HungNien Chen
2015-07-12 6:28 ` Dmitry Torokhov [this message]
2015-07-13 11:47 ` Hn Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150712062847.GA37026@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=charliemooney@google.com \
--cc=hn.chen@weidahitech.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).