From: Sebastian Reichel <sre@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
Michael Welling <mwelling@emacinc.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Input: tsc2005 - convert to gpiod
Date: Thu, 16 Jul 2015 00:09:41 +0200 [thread overview]
Message-ID: <20150715220940.GD2591@earth> (raw)
In-Reply-To: <20150715213404.GC24393@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
Hi,
On Wed, Jul 15, 2015 at 02:34:04PM -0700, Dmitry Torokhov wrote:
> [...]
> > if (np) {
> > - ts->reset_gpio = of_get_named_gpio(np, "reset-gpios", 0);
> > - if (ts->reset_gpio == -EPROBE_DEFER)
> > - return ts->reset_gpio;
> > - if (ts->reset_gpio < 0) {
> > + ts->reset_gpio = devm_gpiod_get(&spi->dev, "reset",
> > + GPIOD_OUT_HIGH);
>
> I think we should treat the gpio as optional and try to get the
> descriptor event on non-OF boards.
As I wrote in the cover letter, I suggest to change this once the
Nokia N900 board code has been removed. At that point changing the
board code API is much easier, since it won't affect multiple trees.
> [...]
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-15 22:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 12:13 [PATCH 0/4] [input] tsc2005 cleanup Sebastian Reichel
2015-07-15 12:13 ` [PATCH 1/4] Input: tsc2005 - improve readability of register defines Sebastian Reichel
2015-07-15 12:13 ` [PATCH 2/4] Input: tsc2005 - convert to regmap Sebastian Reichel
2015-07-15 21:29 ` Dmitry Torokhov
2015-07-15 21:48 ` Dmitry Torokhov
2015-07-15 21:54 ` Sebastian Reichel
2015-07-16 6:34 ` Dmitry Torokhov
2015-07-15 12:13 ` [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition Sebastian Reichel
2015-07-15 21:31 ` Dmitry Torokhov
2015-07-15 22:02 ` Sebastian Reichel
2015-07-16 0:22 ` Dmitry Torokhov
2015-07-15 12:13 ` [PATCH 4/4] Input: tsc2005 - convert to gpiod Sebastian Reichel
2015-07-15 21:34 ` Dmitry Torokhov
2015-07-15 22:09 ` Sebastian Reichel [this message]
2015-07-16 0:25 ` Dmitry Torokhov
2015-07-16 9:14 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715220940.GD2591@earth \
--to=sre@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mwelling@emacinc.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).