From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: linux-input@vger.kernel.org,
Michael Welling <mwelling@emacinc.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Input: tsc2005 - convert to regmap
Date: Wed, 15 Jul 2015 23:34:23 -0700 [thread overview]
Message-ID: <20150716063423.GA5690@dtor-ws> (raw)
In-Reply-To: <1436962408-5206-3-git-send-email-sre@kernel.org>
On Wed, Jul 15, 2015 at 02:13:26PM +0200, Sebastian Reichel wrote:
> -static int tsc2005_write(struct tsc2005 *ts, u8 reg, u16 value)
> -{
> - u32 tx = ((reg | TSC2005_REG_PND0) << 16) | value;
> - struct spi_transfer xfer = {
> - .tx_buf = &tx,
> - .len = 4,
> - .bits_per_word = 24,
> - };
I wonder why the original code used 24 bit-sized-words for transfers...
--
Dmitry
next prev parent reply other threads:[~2015-07-16 6:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 12:13 [PATCH 0/4] [input] tsc2005 cleanup Sebastian Reichel
2015-07-15 12:13 ` [PATCH 1/4] Input: tsc2005 - improve readability of register defines Sebastian Reichel
2015-07-15 12:13 ` [PATCH 2/4] Input: tsc2005 - convert to regmap Sebastian Reichel
2015-07-15 21:29 ` Dmitry Torokhov
2015-07-15 21:48 ` Dmitry Torokhov
2015-07-15 21:54 ` Sebastian Reichel
2015-07-16 6:34 ` Dmitry Torokhov [this message]
2015-07-15 12:13 ` [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition Sebastian Reichel
2015-07-15 21:31 ` Dmitry Torokhov
2015-07-15 22:02 ` Sebastian Reichel
2015-07-16 0:22 ` Dmitry Torokhov
2015-07-15 12:13 ` [PATCH 4/4] Input: tsc2005 - convert to gpiod Sebastian Reichel
2015-07-15 21:34 ` Dmitry Torokhov
2015-07-15 22:09 ` Sebastian Reichel
2015-07-16 0:25 ` Dmitry Torokhov
2015-07-16 9:14 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716063423.GA5690@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mwelling@emacinc.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).