From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH 1/1] Input - alps: Fix button reporting on the V2 Alps protocol Date: Thu, 30 Jul 2015 16:45:10 +0200 Message-ID: <20150730144510.GF26714@pali> References: <1438202726-5100-1-git-send-email-cpaul@redhat.com> <1438202726-5100-2-git-send-email-cpaul@redhat.com> <55BA2BDD.90108@redhat.com> <20150730141132.GC26714@pali> <55BA3247.3000900@redhat.com> <20150730142839.GD26714@pali> <20150730143240.GE26714@pali> <55BA36F7.3050703@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:32805 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbbG3OpN (ORCPT ); Thu, 30 Jul 2015 10:45:13 -0400 Received: by wicmv11 with SMTP id mv11so24157591wic.0 for ; Thu, 30 Jul 2015 07:45:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55BA36F7.3050703@redhat.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Hans de Goede Cc: cpaul@redhat.com, Douglas Christman , Benjamin Tissoires , linux-input , Dmitry Torokhov On Thursday 30 July 2015 16:38:47 Hans de Goede wrote: > Hi, >=20 > On 30-07-15 16:32, Pali Roh=C3=A1r wrote: > >On Thursday 30 July 2015 16:28:39 Pali Roh=C3=A1r wrote: > >>On Thursday 30 July 2015 16:18:47 Hans de Goede wrote: > >>>Hi, > >>> > >>>On 30-07-15 16:11, Pali Roh=C3=A1r wrote: > >>>>On Thursday 30 July 2015 15:51:25 Hans de Goede wrote: > >>>>>Hi Chandler, > >>>>> > >>>>>On 29-07-15 22:45, cpaul@redhat.com wrote: > >>>>>>From: Stephen Chandler Paul > >>>>>> > >>>>>>The data concerning which buttons on the touchpad are held down= or not > >>>>>>are in the fourth packet we receive from the mouse, not the fir= st. > >>>>>> > >>>>>>Signed-off-by: Stephen Chandler Paul > >>>>>>--- > >>>>>> drivers/input/mouse/alps.c | 6 +++--- > >>>>>> 1 file changed, 3 insertions(+), 3 deletions(-) > >>>>>> > >>>>>>diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/a= lps.c > >>>>>>index 113d6f1..e2f9b25 100644 > >>>>>>--- a/drivers/input/mouse/alps.c > >>>>>>+++ b/drivers/input/mouse/alps.c > >>>>>>@@ -254,9 +254,9 @@ static void alps_process_packet_v1_v2(struc= t psmouse *psmouse) > >>>>>> /* Non interleaved V2 dualpoint has separate stick button bi= ts */ > >>>>>> if (priv->proto_version =3D=3D ALPS_PROTO_V2 && > >>>>>> priv->flags =3D=3D (ALPS_PASS | ALPS_DUALPOINT)) { > >>>>>>- left |=3D packet[0] & 1; > >>>>>>- right |=3D packet[0] & 2; > >>>>>>- middle |=3D packet[0] & 4; > >>>>>>+ left |=3D packet[3] & 1; > >>>>>>+ right |=3D packet[3] & 2; > >>>>>>+ middle |=3D packet[3] & 4; > >>>>>> } > >>>>>> > >>>>>> alps_report_buttons(dev, dev2, left, right, middle); > >>>>> > >>>>>Thanks for taking a look at the recordings, but the above patch = is wrong, > >>>>>if you look slightly higher in the lps_process_packet_v1_v2() fu= nction there > >>>>>is this: > >>>>> > >>>>>if (priv->proto_version =3D=3D ALPS_PROTO_V1) { > >>>>>... > >>>>>} else { > >>>>> left =3D packet[3] & 1; > >>>>> right =3D packet[3] & 2; > >>>>> middle =3D packet[3] & 4; > >>>>>} > >>>>> > >>>>>So with your patch for the devices in question the entire code f= low > >>>>>becomes: > >>>>> > >>>>> left =3D packet[3] & 1; > >>>>> right =3D packet[3] & 2; > >>>>> middle =3D packet[3] & 4; > >>>>> left |=3D packet[3] & 1; > >>>>> right |=3D packet[3] & 2; > >>>>> middle |=3D packet[3] & 4; > >>>>> > >>>>>Which is not really helpful for the devices for which I added > >>>>>commit 92bac83dd: > >>>>> > >>>>>https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/= commit/drivers/input/mouse/alps.c?id=3D92bac83dd79e60e65c475222e41a992a= 70434beb > >>>>> > >>>>>and will cause these devices to regress. > >>>>> > >>>>>Since Hans de Bruin's laptop is a Dell Latitude D430 and I saw > >>>>>the same problem and tested my patch on a Dell Latitude D630, > >>>>>it seems the use of the low bits of packet[0] to report the > >>>>>trackpoint buttons separately when the touchpad is active is > >>>>>a Dell specific thing, so I believe that a patch to only > >>>>>activate this code block on Dell's is the right solution for > >>>>>the regression Douglas is seeing. > >>>>> > >>>>>I'll write such a patch and post it shortly. > >>>>> > >>>>>Regards, > >>>>> > >>>>>Hans > >>>>> > >>>>> > >>>>> > >>>> > >>>>Hans, can you check ec and e7 registers if are same or if they di= ffers? > >>> > >>>As Benjamin already pointed out Douglas' touchpad matches this > >>>line in alps.c : > >>> > >>>{ { 0x22, 0x02, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff, ALPS_PA= SS | ALPS_DUALPOINT } }, /* Dell Latitude D600 */ > >>> > >>>This is a full match > >> > >>No, this is not full match. It just check e7, not ec. This is reaso= n why > >>I asked for both ec and e7 registers of all affected machines. > >> > > > >Douglas already sent e7 and ec regs: > >[ 6.617471] psmouse serio1: alps: E7 report: 22 02 14 > >[ 6.656974] psmouse serio1: alps: EC report: 10 00 64 > > > >Can you post ec regs from your tested Dell machine? >=20 > [ 1.906031] psmouse serio1: alps: EC report: 10 00 64 >=20 > Regards, >=20 > Hans Ok, in this case DMI based check is maybe only possible solution. --=20 Pali Roh=C3=A1r pali.rohar@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html