linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Nick Dyer <nick.dyer@itdev.co.uk>
Cc: linux-input@vger.kernel.org, Alan Bowens <Alan.Bowens@atmel.com>
Subject: Re: [PATCH 2/9] Input: atmel_mxt_ts - use deep sleep mode when stopped
Date: Tue, 4 Aug 2015 17:02:12 -0700	[thread overview]
Message-ID: <20150805000212.GB20765@dtor-ws> (raw)
In-Reply-To: <1438615397-17112-3-git-send-email-nick.dyer@itdev.co.uk>

On Mon, Aug 03, 2015 at 04:23:10PM +0100, Nick Dyer wrote:
> The hardcoded 0x83 CTRL setting overrides other settings in that byte,
> enabling extra reporting that may not be useful on a particular platform.
> 
> Implement improved suspend mechanism via deep sleep. By writing zero to
> both the active and idle cycle times the maXTouch device can be put into a
> deep sleep mode, using minimal power. It is necessary to issue a calibrate
> command after the chip has spent any time in deep sleep, however a soft
> reset is unnecessary.
> 
> Use the old method on Chromebook Pixel via platform data option.
> 
> This patch also deals with the situation where the power configuration is
> zero on probe, which would mean that the device never wakes up to execute
> commands.
> 
> After a config download, the T7 power configuration may have changed so it
> is necessary to re-read it.
> 
> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
> Acked-by: Benson Leung <bleung@chromium.org>
> Acked-by: Yufeng Shen <miletus@chromium.org>
> ---
>  .../devicetree/bindings/input/atmel,maxtouch.txt   |   5 +

Since the T9 code is for compatibility with old Pixel only I do not
think we should be adding it to device tree binding, at least not at the
moment. I cut the device tree parsing out and default to deep sleep on
DT-based systems.

Thanks.

-- 
Dmitry

  reply	other threads:[~2015-08-05  0:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 15:23 atmel_mxt_ts - suspend patch and minor fixes Nick Dyer
2015-08-03 15:23 ` [PATCH 1/9] MAINTAINERS: Add maintainer for atmel_mxt_ts Nick Dyer
2015-08-03 15:23 ` [PATCH 2/9] Input: atmel_mxt_ts - use deep sleep mode when stopped Nick Dyer
2015-08-05  0:02   ` Dmitry Torokhov [this message]
2015-08-06 13:04     ` Nick Dyer
2015-08-06 22:57       ` Dmitry Torokhov
2015-08-10 20:11   ` Benjamin Tissoires
2015-08-11 14:24     ` Nick Dyer
2015-08-11 15:55       ` Nick Dyer
2015-08-11 16:29         ` Benjamin Tissoires
2015-08-11 18:32           ` Nick Dyer
2015-08-03 15:23 ` [PATCH 3/9] Input: atmel_mxt_ts - remove unused defines Nick Dyer
2015-08-03 15:23 ` [PATCH 4/9] Input: atmel_mxt_ts - move mxt_initialize after sysfs init Nick Dyer
2015-08-05  0:00   ` Dmitry Torokhov
2015-08-03 15:23 ` [PATCH 5/9] Input: atmel_mxt_ts - suspend/resume causes panic if input_dev fails to init Nick Dyer
2015-08-03 15:23 ` [PATCH 6/9] Input: atmel_mxt_ts - improve device tree parsing Nick Dyer
2015-08-03 15:23 ` [PATCH 7/9] Input: atmel_mxt_ts - disable interrupt for 50ms after reset Nick Dyer
2015-08-03 15:23 ` [PATCH 8/9] Input: atmel_mxt_ts - initialise input slots with INPUT_MT_DIRECT Nick Dyer
2015-08-03 15:23 ` [PATCH 9/9] Input: atmel_mxt_ts - remove warning on zero T44 count Nick Dyer
2015-08-05  0:03 ` atmel_mxt_ts - suspend patch and minor fixes Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150805000212.GB20765@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=Alan.Bowens@atmel.com \
    --cc=linux-input@vger.kernel.org \
    --cc=nick.dyer@itdev.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).