From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH V3 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver Date: Wed, 5 Aug 2015 03:55:19 +0200 Message-ID: <20150805015519.GZ3486@piout.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: S Twiss Cc: Alessandro Zummo , DEVICETREE , LINUXINPUT , LINUXKERNEL , RTCLINUX , David Dajun Chen , Ian Campbell , Kumar Gala , Lee Jones , Mark Rutland , Pawel Moll , Rob Herring , Samuel Ortiz , Support Opensource List-Id: linux-input@vger.kernel.org On 21/07/2015 at 11:29:07 +0100, S Twiss wrote : > From: S Twiss > > Add DA9062 RTC support into the existing DA9063 RTC driver component by > using generic access tables for common register and bit mask definitions. > > The following change will add generic register and bit mask support to the > DA9063 RTC. The changes are slightly complicated by requiring support for > three register sets: DA9063-AD, DA9063-BB and DA9062-AA. > > The following alterations have been made to the DA9063 RTC: > > - Addition of a da9063_compatible_rtc_regmap structure to hold all generic > registers and bitmasks for this type of RTC component. > - A re-write of struct da9063 to use pointers for regmap and compatible > registers/masks definitions > - Addition of a of_device_id table for DA9063 and DA9062 defaults > - Refactoring functions to use struct da9063_compatible_rtc accesses to > generic registers/masks instead of using defines from registers.h > - Re-work of da9063_rtc_probe() to use of_match_node() and dev_get_regmap() > to provide initialisation of generic registers and masks and access to > regmap > > Signed-off-by: Steve Twiss > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com