From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: ac97: Switch to dev_pm_ops
Date: Fri, 7 Aug 2015 09:32:13 -0700 [thread overview]
Message-ID: <20150807163213.GB30852@dtor-ws> (raw)
In-Reply-To: <55C468BC.60500@metafoo.de>
On Fri, Aug 07, 2015 at 10:13:48AM +0200, Lars-Peter Clausen wrote:
> On 08/07/2015 12:55 AM, Dmitry Torokhov wrote:
> [...]
> >>
> >> -#ifdef CONFIG_PM
> >> -static int wm97xx_suspend(struct device *dev, pm_message_t state)
> >> +#ifdef CONFIG_PM_SLEEP
> >> +static int wm97xx_suspend(struct device *dev)
> >
> > While we are changing it please drop #ifdef CONFIG_PM_SLEEP and annotate
> > suspend and resume with __maybe_unused.
>
> We know that it is used when CONFIG_PM_SLEEP is defined and we know that it
> is unused CONFIG_PM_SLEEP is not defined. Marking the function as
> __maybe_unused will cause the compiler to not generate a warning when the
> function is really unused. Making this explicit works much better.
It will also drop the code form the final image and having the functions
in provides better compile coverage.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-08-07 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 19:42 [PATCH] ALSA: ac97: Switch to dev_pm_ops Lars-Peter Clausen
2015-08-06 22:55 ` Dmitry Torokhov
2015-08-07 8:13 ` Lars-Peter Clausen
2015-08-07 13:30 ` Mark Brown
2015-08-07 16:30 ` Dmitry Torokhov
2015-08-07 16:38 ` Mark Brown
2015-08-07 16:32 ` Dmitry Torokhov [this message]
2015-08-20 16:33 ` Mark Brown
2015-08-20 16:35 ` Lars-Peter Clausen
2015-08-20 17:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807163213.GB30852@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).