Re: [PATCH] HID: gembird: add new driver to fix Gembird JPD-DualForce 2

[Orivej Desh <orivej@gmx.fr>]

-linux-kernel@vger.kernel.org
-jkosina@suse.com

* Benjamin Tissoires
> Hmm... This was actually my first shot, and I noticed that the
> flickering original Z axis was now taking over the correct X axis. So
> that's why I added some complexity to ignore at the HID level this axis.
> I just forgot to update the comment :)

How did you notice that?  Is there a tool in hid-replay?  I did not test
my edition of the patch extensively because I did not expect such a
subtle difference.  Yet I did not observe flickering when joypad was
idle.

I assumed that the commit that hid Rx axis in 3.18 by calling
"map_abs_clear(usage->hid & 0xf);" effectively removed any influence of
repeated axes in report description, but now it seems I am wrong.  Would
you explain what it really did?

> If you think this patch is good enough (you will get flickering X), we
> can carry on this one, but I think the one I submitted (with the comment
> edited) would provide a better experience.

In this case I certainly prefer your original patch.