From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property
Date: Thu, 13 Aug 2015 09:05:38 +0900 [thread overview]
Message-ID: <20150813000537.GD5221@verge.net.au> (raw)
In-Reply-To: <20150708005148.GA28100@verge.net.au>
On Wed, Jul 08, 2015 at 09:51:49AM +0900, Simon Horman wrote:
> On Tue, Jul 07, 2015 at 09:56:29AM +0300, Laurent Pinchart wrote:
> > Hi Simon,
> >
> > On Tuesday 07 July 2015 09:26:21 Simon Horman wrote:
> > > On Mon, Jul 06, 2015 at 04:29:33PM +0300, Laurent Pinchart wrote:
> > > > On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
> > > > > Replace the deprecated generic "adi,adxl34x" compatible value by the
> > > > > adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
> > > > > i2c: Deprecate adi,adxl34x compatible string").
> > > > >
> > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > >
> > > > > ---
> > > > > Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match
> > > > > support"), which is in v4.2-rc1.
> > > > >
> > > > > This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible
> > > > > property".
> > >
> > > It appears to me that this will cause a regression when booting old kernels
> > > with new dts blobs. For that reason think we should consider v1
> > > of this change coupled with a schedule to remove use of the deprecated
> > > compat string.
> >
> > That's the forward compatibility that Geert mentioned, is that really an
> > issue, especially on this board ?
>
> I think it would be best to provide backwards compatibility unless there
> is a compelling reason not to.
I would like to revisit this discussion with a view to getting some version
of this patch queued up (yes I know I pushed back on it earlier in this thread).
next prev parent reply other threads:[~2015-08-13 0:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 10:55 [PATCH v2] ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property Geert Uytterhoeven
[not found] ` <1436180132-26190-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2015-07-06 13:29 ` Laurent Pinchart
2015-07-07 0:26 ` Simon Horman
[not found] ` <20150707002621.GD13326-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-07-07 6:56 ` Laurent Pinchart
2015-07-08 0:51 ` Simon Horman
2015-08-13 0:05 ` Simon Horman [this message]
2015-08-13 9:26 ` Geert Uytterhoeven
2015-08-13 21:31 ` Laurent Pinchart
2015-08-14 4:54 ` Simon Horman
2015-08-14 5:17 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813000537.GD5221@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).