From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Matt Ranostay <mranostay@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH v3 1/1] cap11xx: add runtime PM support
Date: Thu, 20 Aug 2015 17:37:43 -0700 [thread overview]
Message-ID: <20150821003743.GA24710@localhost> (raw)
In-Reply-To: <1439947289-10750-2-git-send-email-mranostay@gmail.com>
Hi Matt,
On Tue, Aug 18, 2015 at 06:21:29PM -0700, Matt Ranostay wrote:
>
> +static int cap11xx_i2c_remove(struct i2c_client *i2c_client)
> +{
> + struct cap11xx_priv *priv = i2c_get_clientdata(i2c_client);
> +
> + cap11xx_set_sleep(priv, true);
> + pm_runtime_disable(&i2c_client->dev);
> + pm_runtime_set_suspended(&i2c_client->dev);
As I mentioned in my previous review:
> This violates ordering: the leds and input device are still open and
> may get requests while you are putting the device to sleep.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-08-21 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 1:21 [PATCH v3 0/1] cap11xx: add runtime PM support Matt Ranostay
2015-08-19 1:21 ` [PATCH v3 1/1] " Matt Ranostay
2015-08-21 0:37 ` Dmitry Torokhov [this message]
2015-08-21 2:07 ` Matt Ranostay
2015-08-21 16:35 ` Dmitry Torokhov
2015-08-22 5:57 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821003743.GA24710@localhost \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).