From: Michele Curti <michele.curti@gmail.com>
To: DusonLin <dusonlin@emc.com.tw>
Cc: jikos@kernel.org, dmitry.torokhov@gmail.com, bleung@chromium.org,
k.kozlowski@samsung.com, charliemooney@chromium.org,
benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: elan_i2c - enable ELAN0100 acpi panels
Date: Sat, 22 Aug 2015 09:39:17 +0200 [thread overview]
Message-ID: <20150822073917.GA586@asus> (raw)
In-Reply-To: <005d01d0dcac$222f3870$668da950$@emc.com.tw>
On Sat, Aug 22, 2015 at 03:28:19PM +0800, DusonLin wrote:
> Hi Michele,
>
> The vaildpage_count for type 0x08 should be 512, not 768.
>
Thank you! Sent a v2 patch :)
Regards,
Michele
> Thanks
> Duson
>
> -----Original Message-----
> From: Michele Curti [mailto:michele.curti@gmail.com]
> Sent: Saturday, August 22, 2015 2:59 PM
> To: jikos@kernel.org; dmitry.torokhov@gmail.com; dusonlin@emc.com.tw
> Cc: bleung@chromium.org; k.kozlowski@samsung.com;
> charliemooney@chromium.org; benjamin.tissoires@redhat.com;
> linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; Michele Curti
> Subject: [PATCH] Input: elan_i2c - enable ELAN0100 acpi panels
>
> Enable ELAN0100 touchpad driver, found on a Asus X205TA laptop, to gain 2,3
> fingers tap and 2 fingers scroll.
>
> Signed-off-by: Michele Curti <michele.curti@gmail.com>
> ---
> drivers/hid/hid-core.c | 1 +
> drivers/input/mouse/elan_i2c_core.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index
> 22afab9..70a11ac 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2294,6 +2294,7 @@ static const struct hid_device_id hid_ignore_list[] =
> {
> { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x0004) },
> { HID_USB_DEVICE(USB_VENDOR_ID_DREAM_CHEEKY, 0x000a) },
> { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x0400) },
> + { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, 0x0401) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY,
> USB_DEVICE_ID_ESSENTIAL_REALITY_P5) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) }, diff
> --git a/drivers/input/mouse/elan_i2c_core.c
> b/drivers/input/mouse/elan_i2c_core.c
> index 67388f4..3f1eef0 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -98,6 +98,7 @@ static int elan_get_fwinfo(u8 ic_type, u16
> *vaildpage_count,
> u16 *signature_address)
> {
> switch(ic_type) {
> + case 0x08:
>
>
> case 0x09:
> *vaildpage_count = 768;
> break;
> @@ -1165,6 +1166,7 @@ MODULE_DEVICE_TABLE(i2c, elan_id); #ifdef CONFIG_ACPI
> static const struct acpi_device_id elan_acpi_id[] = {
> { "ELAN0000", 0 },
> + { "ELAN0100", 0 },
> { "ELAN0600", 0 },
> { }
> };
> --
> 2.5.0
>
>
prev parent reply other threads:[~2015-08-22 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 6:58 [PATCH] Input: elan_i2c - enable ELAN0100 acpi panels Michele Curti
2015-08-22 7:28 ` DusonLin
2015-08-22 7:39 ` Michele Curti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150822073917.GA586@asus \
--to=michele.curti@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bleung@chromium.org \
--cc=charliemooney@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dusonlin@emc.com.tw \
--cc=jikos@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).