linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Kalle Jokiniemi <kalle.jokiniemi@jolla.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 1/1] input: ff-memless: Change FF_ENVELOPE_INTERVAL to a module parameter.
Date: Fri, 28 Aug 2015 17:29:25 -0700	[thread overview]
Message-ID: <20150829002925.GA8298@dtor-ws> (raw)
In-Reply-To: <1440762993-31329-1-git-send-email-kalle.jokiniemi@jolla.com>

Hi Kalle,

On Fri, Aug 28, 2015 at 02:56:33PM +0300, Kalle Jokiniemi wrote:
> Sometimes you need to have tighter control over the ff-memless
> effects. E.g. when creating short button / VKB press effects,
> the effect duration is typically <= 40ms, and you want to have
> a short acceleration period in beginning and fade out the end
> to avoid "electric tooth brush" effect. With 50ms envelope
> interval this control is not possible.
> 
> To allow this control without patching over ff-memless, change the
> FF_ENVELOPE_INTERVAL macro to a module parameter that can be modified
> via kernel command line or during runtime from
> /sys/module/ff_memless/parameters/ff_envelope_interval sysfs file.

How would users know that they need to change this parameter? Could we
maybe adjust sampling time dynamically, based on the attack length of
the envelope?

Thanks.

-- 
Dmitry

  reply	other threads:[~2015-08-29  0:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28 11:56 [PATCH 1/1] input: ff-memless: Change FF_ENVELOPE_INTERVAL to a module parameter Kalle Jokiniemi
2015-08-29  0:29 ` Dmitry Torokhov [this message]
2015-08-31  8:47   ` Kalle Jokiniemi
2015-09-03 17:41     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150829002925.GA8298@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=kalle.jokiniemi@jolla.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).