linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benson Leung <bleung@chromium.org>
Cc: dusonlin@emc.com.tw, michele.curti@gmail.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: elan_i2c - Fix typos for validpage_count
Date: Fri, 28 Aug 2015 17:30:39 -0700	[thread overview]
Message-ID: <20150829003039.GB8298@dtor-ws> (raw)
In-Reply-To: <1440613171-20549-1-git-send-email-bleung@chromium.org>

On Wed, Aug 26, 2015 at 11:19:31AM -0700, Benson Leung wrote:
> Search for "vaildpage_count" and replace with "validpage_count".
> 
> Signed-off-by: Benson Leung <bleung@chromium.org>

Applied, thank you.

> ---
>  drivers/input/mouse/elan_i2c_core.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index bbdaedc..d4a38ca 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -84,7 +84,7 @@ struct elan_tp_data {
>  	int			pressure_adjustment;
>  	u8			mode;
>  	u8			ic_type;
> -	u16			fw_vaildpage_count;
> +	u16			fw_validpage_count;
>  	u16			fw_signature_address;
>  
>  	bool			irq_wake;
> @@ -94,28 +94,28 @@ struct elan_tp_data {
>  	bool			baseline_ready;
>  };
>  
> -static int elan_get_fwinfo(u8 ic_type, u16 *vaildpage_count,
> +static int elan_get_fwinfo(u8 ic_type, u16 *validpage_count,
>  			   u16 *signature_address)
>  {
>  	switch(ic_type) {
>  	case 0x08:
> -		*vaildpage_count = 512;
> +		*validpage_count = 512;
>  		break;
>  	case 0x09:
> -		*vaildpage_count = 768;
> +		*validpage_count = 768;
>  		break;
>  	case 0x0D:
> -		*vaildpage_count = 896;
> +		*validpage_count = 896;
>  		break;
>  	default:
>  		/* unknown ic type clear value */
> -		*vaildpage_count = 0;
> +		*validpage_count = 0;
>  		*signature_address = 0;
>  		return -ENXIO;
>  	}
>  
>  	*signature_address =
> -		(*vaildpage_count * ETP_FW_PAGE_SIZE) - ETP_FW_SIGNATURE_SIZE;
> +		(*validpage_count * ETP_FW_PAGE_SIZE) - ETP_FW_SIGNATURE_SIZE;
>  
>  	return 0;
>  }
> @@ -264,7 +264,7 @@ static int elan_query_device_info(struct elan_tp_data *data)
>  	if (error)
>  		return error;
>  
> -	error = elan_get_fwinfo(data->ic_type, &data->fw_vaildpage_count,
> +	error = elan_get_fwinfo(data->ic_type, &data->fw_validpage_count,
>  				&data->fw_signature_address);
>  	if (error) {
>  		dev_err(&data->client->dev,
> @@ -356,7 +356,7 @@ static int __elan_update_firmware(struct elan_tp_data *data,
>  	iap_start_addr = get_unaligned_le16(&fw->data[ETP_IAP_START_ADDR * 2]);
>  
>  	boot_page_count = (iap_start_addr * 2) / ETP_FW_PAGE_SIZE;
> -	for (i = boot_page_count; i < data->fw_vaildpage_count; i++) {
> +	for (i = boot_page_count; i < data->fw_validpage_count; i++) {
>  		u16 checksum = 0;
>  		const u8 *page = &fw->data[i * ETP_FW_PAGE_SIZE];
>  
> -- 
> 2.5.0.457.gab17608
> 

-- 
Dmitry

      reply	other threads:[~2015-08-29  0:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26 18:19 [PATCH] Input: elan_i2c - Fix typos for validpage_count Benson Leung
2015-08-29  0:30 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150829003039.GB8298@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=bleung@chromium.org \
    --cc=dusonlin@emc.com.tw \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michele.curti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).