* [PATCH] Input: max8997_haptic - Fix module alias
@ 2015-08-26 0:19 Javier Martinez Canillas
2015-08-29 0:31 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2015-08-26 0:19 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Jingoo Han, Wolfram Sang,
Dmitry Torokhov, linux-input
The driver is a platform driver and not a I2C driver so its modalias
should be exported with MODULE_DEVICE_TABLE(platform,...) instead of
MODULE_DEVICE_TABLE(i2c,...).
Also, remove the unnecessary MODULE_ALIAS("platform:max8997-haptic")
now that the correct module alias is created.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/input/misc/max8997_haptic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/misc/max8997_haptic.c b/drivers/input/misc/max8997_haptic.c
index d0f687281339..a806ba3818f7 100644
--- a/drivers/input/misc/max8997_haptic.c
+++ b/drivers/input/misc/max8997_haptic.c
@@ -394,7 +394,7 @@ static const struct platform_device_id max8997_haptic_id[] = {
{ "max8997-haptic", 0 },
{ },
};
-MODULE_DEVICE_TABLE(i2c, max8997_haptic_id);
+MODULE_DEVICE_TABLE(platform, max8997_haptic_id);
static struct platform_driver max8997_haptic_driver = {
.driver = {
@@ -407,7 +407,6 @@ static struct platform_driver max8997_haptic_driver = {
};
module_platform_driver(max8997_haptic_driver);
-MODULE_ALIAS("platform:max8997-haptic");
MODULE_AUTHOR("Donggeun Kim <dg77.kim@samsung.com>");
MODULE_DESCRIPTION("max8997_haptic driver");
MODULE_LICENSE("GPL");
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: max8997_haptic - Fix module alias
2015-08-26 0:19 [PATCH] Input: max8997_haptic - Fix module alias Javier Martinez Canillas
@ 2015-08-29 0:31 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-08-29 0:31 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Jingoo Han, Wolfram Sang, linux-input
On Wed, Aug 26, 2015 at 02:19:41AM +0200, Javier Martinez Canillas wrote:
> The driver is a platform driver and not a I2C driver so its modalias
> should be exported with MODULE_DEVICE_TABLE(platform,...) instead of
> MODULE_DEVICE_TABLE(i2c,...).
>
> Also, remove the unnecessary MODULE_ALIAS("platform:max8997-haptic")
> now that the correct module alias is created.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
>
> ---
>
> drivers/input/misc/max8997_haptic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/max8997_haptic.c b/drivers/input/misc/max8997_haptic.c
> index d0f687281339..a806ba3818f7 100644
> --- a/drivers/input/misc/max8997_haptic.c
> +++ b/drivers/input/misc/max8997_haptic.c
> @@ -394,7 +394,7 @@ static const struct platform_device_id max8997_haptic_id[] = {
> { "max8997-haptic", 0 },
> { },
> };
> -MODULE_DEVICE_TABLE(i2c, max8997_haptic_id);
> +MODULE_DEVICE_TABLE(platform, max8997_haptic_id);
>
> static struct platform_driver max8997_haptic_driver = {
> .driver = {
> @@ -407,7 +407,6 @@ static struct platform_driver max8997_haptic_driver = {
> };
> module_platform_driver(max8997_haptic_driver);
>
> -MODULE_ALIAS("platform:max8997-haptic");
> MODULE_AUTHOR("Donggeun Kim <dg77.kim@samsung.com>");
> MODULE_DESCRIPTION("max8997_haptic driver");
> MODULE_LICENSE("GPL");
> --
> 2.4.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-29 0:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-26 0:19 [PATCH] Input: max8997_haptic - Fix module alias Javier Martinez Canillas
2015-08-29 0:31 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).