From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: duson <dusonlin@emc.com.tw>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: elan_i2c - Use iap_version to get firmware information
Date: Thu, 3 Sep 2015 09:57:19 -0700 [thread overview]
Message-ID: <20150903165719.GA17498@dtor-ws> (raw)
In-Reply-To: <E043392A-A8F9-40C7-A273-3B20AA3F00D8@emc.com.tw>
On Wed, Sep 02, 2015 at 09:03:46AM +0800, duson wrote:
> When driver get exception ic type (0xFF), maybe occurred from wrong
> I2C protocol communication, system crash or other unknown situation,
> instead of ic_type we use iap_version to get firmware information.
>
> Signed-off-by: Duson Lin <dusonlin@emc.com.tw>
> ---
> drivers/input/mouse/elan_i2c_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index 5b5f403..d99d40c 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -4,7 +4,7 @@
> * Copyright (c) 2013 ELAN Microelectronics Corp.
> *
> * Author: 林政維 (Duson Lin) <dusonlin@emc.com.tw>
> - * Version: 1.5.9
> + * Version: 1.6.0
> *
> * Based on cyapa driver:
> * copyright (c) 2011-2012 Cypress Semiconductor, Inc.
> @@ -40,7 +40,7 @@
> #include "elan_i2c.h"
>
> #define DRIVER_NAME "elan_i2c"
> -#define ELAN_DRIVER_VERSION "1.5.9"
> +#define ELAN_DRIVER_VERSION "1.6.0"
> #define ETP_MAX_PRESSURE 255
> #define ETP_FWIDTH_REDUCE 90
> #define ETP_FINGER_WIDTH 15
> @@ -261,11 +261,11 @@ static int elan_query_device_info(struct elan_tp_data *data)
> if (error)
> return error;
>
> - error = elan_get_fwinfo(data->ic_type, &data->fw_vaildpage_count,
> + error = elan_get_fwinfo(data->iap_version, &data->fw_vaildpage_count,
> &data->fw_signature_address);
> if (error) {
> dev_err(&data->client->dev,
> - "unknown ic type %d\n", data->ic_type);
> + "unknown ic type %d\n", data->iap_version);
Applied but changed the working here to "unknown iap version" and also
changed argument name in elan_get_fwinfo.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-03 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 1:03 [PATCH] Input: elan_i2c - Use iap_version to get firmware information duson
2015-09-03 16:57 ` Dmitry Torokhov [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-02 0:45 duson
2015-09-02 0:55 ` DusonLin
2015-09-02 0:38 duson
2015-09-02 0:55 ` DusonLin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903165719.GA17498@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=dusonlin@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).