From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Ferruh Yigit <fery@cypress.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: cyttsp - Remove unnecessary MODULE_ALIAS()
Date: Thu, 3 Sep 2015 10:48:02 -0700 [thread overview]
Message-ID: <20150903174802.GB19537@dtor-ws> (raw)
In-Reply-To: <1440810324-14382-1-git-send-email-javier@osg.samsung.com>
On Sat, Aug 29, 2015 at 03:05:24AM +0200, Javier Martinez Canillas wrote:
> The drivers have a I2C device ID table that is used to create the module
> aliases and also "cyttsp" and "cyttsp4" are not supported I2C device IDs
> so these module aliases are never used.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
>
> ---
>
> drivers/input/touchscreen/cyttsp4_i2c.c | 1 -
> drivers/input/touchscreen/cyttsp_i2c.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/cyttsp4_i2c.c b/drivers/input/touchscreen/cyttsp4_i2c.c
> index 9a323dd915de..a9f95c7d3c00 100644
> --- a/drivers/input/touchscreen/cyttsp4_i2c.c
> +++ b/drivers/input/touchscreen/cyttsp4_i2c.c
> @@ -86,4 +86,3 @@ module_i2c_driver(cyttsp4_i2c_driver);
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("Cypress TrueTouch(R) Standard Product (TTSP) I2C driver");
> MODULE_AUTHOR("Cypress");
> -MODULE_ALIAS("i2c:cyttsp4");
> diff --git a/drivers/input/touchscreen/cyttsp_i2c.c b/drivers/input/touchscreen/cyttsp_i2c.c
> index 519e2de2f8df..eee51b3f2e3f 100644
> --- a/drivers/input/touchscreen/cyttsp_i2c.c
> +++ b/drivers/input/touchscreen/cyttsp_i2c.c
> @@ -86,4 +86,3 @@ module_i2c_driver(cyttsp_i2c_driver);
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("Cypress TrueTouch(R) Standard Product (TTSP) I2C driver");
> MODULE_AUTHOR("Cypress");
> -MODULE_ALIAS("i2c:cyttsp");
> --
> 2.4.3
>
--
Dmitry
prev parent reply other threads:[~2015-09-03 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 1:05 [PATCH] Input: cyttsp - Remove unnecessary MODULE_ALIAS() Javier Martinez Canillas
2015-09-03 17:48 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903174802.GB19537@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=fery@cypress.com \
--cc=javier@osg.samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).