* [PATCH v2 3/6] input: regulator-haptic: Fix module autoload for OF platform driver
@ 2015-08-29 10:47 Luis de Bethencourt
2015-09-03 17:50 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-08-29 10:47 UTC (permalink / raw)
To: linux-kernel
Cc: Dmitry Torokhov, Jaewon Kim, Chanwoo Choi, Kyungmin Park,
Fabian Frederick, Axel Lin, linux-input, Javier Martinez Canillas
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---
Better without an empty line between of_device_id and MODULE_DEVICE_TABLE.
Thanks,
Luis
drivers/input/misc/regulator-haptic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/regulator-haptic.c b/drivers/input/misc/regulator-haptic.c
index 6bf3f10..a804705 100644
--- a/drivers/input/misc/regulator-haptic.c
+++ b/drivers/input/misc/regulator-haptic.c
@@ -249,6 +249,7 @@ static const struct of_device_id regulator_haptic_dt_match[] = {
{ .compatible = "regulator-haptic" },
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, regulator_haptic_dt_match);
static struct platform_driver regulator_haptic_driver = {
.probe = regulator_haptic_probe,
--
2.4.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 3/6] input: regulator-haptic: Fix module autoload for OF platform driver
2015-08-29 10:47 [PATCH v2 3/6] input: regulator-haptic: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-03 17:50 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-09-03 17:50 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel, Jaewon Kim, Chanwoo Choi, Kyungmin Park,
Fabian Frederick, Axel Lin, linux-input, Javier Martinez Canillas
On Sat, Aug 29, 2015 at 12:47:26PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
Applied, thank you.
> ---
>
> Better without an empty line between of_device_id and MODULE_DEVICE_TABLE.
>
> Thanks,
> Luis
>
> drivers/input/misc/regulator-haptic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/regulator-haptic.c b/drivers/input/misc/regulator-haptic.c
> index 6bf3f10..a804705 100644
> --- a/drivers/input/misc/regulator-haptic.c
> +++ b/drivers/input/misc/regulator-haptic.c
> @@ -249,6 +249,7 @@ static const struct of_device_id regulator_haptic_dt_match[] = {
> { .compatible = "regulator-haptic" },
> { /* sentinel */ },
> };
> +MODULE_DEVICE_TABLE(of, regulator_haptic_dt_match);
>
> static struct platform_driver regulator_haptic_driver = {
> .probe = regulator_haptic_probe,
> --
> 2.4.6
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-03 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-29 10:47 [PATCH v2 3/6] input: regulator-haptic: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-03 17:50 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).