From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: linux-kernel@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>,
linux-input@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: Re: [PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver
Date: Thu, 3 Sep 2015 10:54:14 -0700 [thread overview]
Message-ID: <20150903175414.GH19537@dtor-ws> (raw)
In-Reply-To: <20150829105055.GA20965@goodgumbo.baconseed.org>
On Sat, Aug 29, 2015 at 12:50:55PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
Already have this one as well.
> ---
>
> Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
> As suggested by Dmitry Torokhov.
>
> Thanks for the review Dmitry,
> Luis
>
> drivers/input/touchscreen/mms114.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
> index 67c0d31..df778f4 100644
> --- a/drivers/input/touchscreen/mms114.c
> +++ b/drivers/input/touchscreen/mms114.c
> @@ -572,6 +572,7 @@ static const struct of_device_id mms114_dt_match[] = {
> { .compatible = "melfas,mms114" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, mms114_dt_match);
> #endif
>
> static struct i2c_driver mms114_driver = {
> --
> 2.4.6
>
--
Dmitry
prev parent reply other threads:[~2015-09-03 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 10:50 [PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-03 17:54 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903175414.GH19537@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=javier@osg.samsung.com \
--cc=jg1.han@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@debethencourt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).