* [PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver
@ 2015-08-29 10:50 Luis de Bethencourt
2015-09-03 17:54 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-08-29 10:50 UTC (permalink / raw)
Cc: Dmitry Torokhov, Jingoo Han, linux-input, linux-kernel,
Javier Martinez Canillas
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---
Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
As suggested by Dmitry Torokhov.
Thanks for the review Dmitry,
Luis
drivers/input/touchscreen/mms114.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
index 67c0d31..df778f4 100644
--- a/drivers/input/touchscreen/mms114.c
+++ b/drivers/input/touchscreen/mms114.c
@@ -572,6 +572,7 @@ static const struct of_device_id mms114_dt_match[] = {
{ .compatible = "melfas,mms114" },
{ }
};
+MODULE_DEVICE_TABLE(of, mms114_dt_match);
#endif
static struct i2c_driver mms114_driver = {
--
2.4.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver
2015-08-29 10:50 [PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-03 17:54 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-09-03 17:54 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel, Jingoo Han, linux-input, Javier Martinez Canillas
On Sat, Aug 29, 2015 at 12:50:55PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
Already have this one as well.
> ---
>
> Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block.
> As suggested by Dmitry Torokhov.
>
> Thanks for the review Dmitry,
> Luis
>
> drivers/input/touchscreen/mms114.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
> index 67c0d31..df778f4 100644
> --- a/drivers/input/touchscreen/mms114.c
> +++ b/drivers/input/touchscreen/mms114.c
> @@ -572,6 +572,7 @@ static const struct of_device_id mms114_dt_match[] = {
> { .compatible = "melfas,mms114" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, mms114_dt_match);
> #endif
>
> static struct i2c_driver mms114_driver = {
> --
> 2.4.6
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-03 17:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-29 10:50 [PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-03 17:54 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).