From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 3/4] input: Add new sun4i-keypad driver Date: Fri, 18 Sep 2015 11:44:31 +0200 Message-ID: <20150918094431.GN4684@lukather> References: <1442325957-10102-1-git-send-email-yassinjaffer@gmail.com> <1442325957-10102-4-git-send-email-yassinjaffer@gmail.com> <20150917130520.GD4684@lukather> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U/fW6JBK3GqE0Htg" Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Yassin Jaffer Cc: "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , Dmitry Torokhov , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org --U/fW6JBK3GqE0Htg Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Yassin, On Fri, Sep 18, 2015 at 10:19:55AM +1000, Yassin Jaffer wrote: > Hi Maxime > > I appreciate your time and efforts . > > Do you need that rate to be enforced, or is it some leftover from the > > allwinner BSP? > > > I've found that clock rate works fine with the default denounce and scan > cycle. It was not really my point. My point was do you *need* it to operate. And so your properties were in clock cycles? Please use a unit indenpendant of the clock rate, like seconds or Hz (or any multiple of them). > By the way do you have any dev board which expose the keypad pins? I don't think I have any. Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --U/fW6JBK3GqE0Htg--