From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: serio - fix blocking of parport
Date: Mon, 28 Sep 2015 19:11:59 +0530 [thread overview]
Message-ID: <20150928134126.GA4536@sudip-pc> (raw)
In-Reply-To: <20150928001808.GA17818@dtor-ws>
On Sun, Sep 27, 2015 at 05:18:08PM -0700, Dmitry Torokhov wrote:
> On Sat, Sep 26, 2015 at 06:53:21PM +0530, Sudip Mukherjee wrote:
> > If parkbd_allocate_serio() fails to allocate memory we are releasing the
> > parport but we missed unregistering the device. As a result this device
> > with exclusive access to that parport remains registered. And no other
> > device will be able to use that parport even though this driver has
> > failed to load.
> >
> > Cc: <stable@vger.kernel.org> # 2.6.32+
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>
> Applied, but I dropped stable annotation - since noone complained about
> this and the issue is in error path that is unlikely anyway, I do not
> think we need to bother stable guys with it.
Ok. Thanks.
BTW, I have two more patches waiting for your review.
1) Input: cyapa: remove variable overwriting
2) Input: omap-keypad: fix memory leak
Did you get a chance to have a look at them?
regards
sudip
prev parent reply other threads:[~2015-09-28 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 13:23 [PATCH] Input: serio - fix blocking of parport Sudip Mukherjee
2015-09-28 0:18 ` Dmitry Torokhov
2015-09-28 13:41 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928134126.GA4536@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).