From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] Input: cyapa: remove variable overwriting Date: Tue, 29 Sep 2015 12:18:02 +0530 Message-ID: <20150929064749.GA23662@sudip-pc> References: <1442311587-24458-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:36760 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755328AbbI2GsM (ORCPT ); Tue, 29 Sep 2015 02:48:12 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Dudley Du , lkml , "linux-input@vger.kernel.org" On Mon, Sep 28, 2015 at 03:43:04PM -0700, Dmitry Torokhov wrote: > Hi Sudip, > > On Tue, Sep 15, 2015 at 3:06 AM, Sudip Mukherjee > wrote: > > Even if rotat_align is true or false the final value of > > cyapa->electrodes_rx is always cyapa->electrodes_y. remove the variable > > overwriting and in the process remove the variable rotat_align which is > > not required any more. > > > > Signed-off-by: Sudip Mukherjee > > --- > > drivers/input/mouse/cyapa_gen6.c | 10 +--------- > > 1 file changed, 1 insertion(+), 9 deletions(-) > > > > diff --git a/drivers/input/mouse/cyapa_gen6.c b/drivers/input/mouse/cyapa_gen6.c > > index 5f19107..f0c614b 100644 > > --- a/drivers/input/mouse/cyapa_gen6.c > > +++ b/drivers/input/mouse/cyapa_gen6.c > > @@ -196,7 +196,6 @@ static int cyapa_gen6_read_sys_info(struct cyapa *cyapa) > > u8 resp_data[PIP_READ_SYS_INFO_RESP_LENGTH]; > > int resp_len; > > u16 product_family; > > - u8 rotat_align; > > int error; > > > > /* Get App System Information to determine Gen5 or Gen6. */ > > @@ -241,14 +240,7 @@ static int cyapa_gen6_read_sys_info(struct cyapa *cyapa) > > memcpy(&cyapa->product_id[13], &resp_data[62], 2); > > cyapa->product_id[15] = '\0'; > > > > - rotat_align = resp_data[68]; > > - if (rotat_align) { > > - cyapa->electrodes_rx = cyapa->electrodes_y; > > - cyapa->electrodes_rx = cyapa->electrodes_y; > > - } else { > > - cyapa->electrodes_rx = cyapa->electrodes_x; > > - cyapa->electrodes_rx = cyapa->electrodes_y; > > - } > > + cyapa->electrodes_rx = cyapa->electrodes_y; > > II think it was probably a typo rather than rotat_align being not > needed. Dudley? maybe some copy paste error. I thought it might have been cyapa->electrodes_ry but there is nothing like that. regards sudip