* [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD
@ 2015-09-28 14:22 Mika Westerberg
2015-09-29 6:37 ` Daniel Martin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mika Westerberg @ 2015-09-28 14:22 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, Mika Westerberg, linux-input
Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call
the device as "Touchpad".
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/hid/hid-multitouch.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 426b2f1a3450..661b4fce1a5d 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -968,6 +968,9 @@ static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
case HID_DG_TOUCHSCREEN:
/* we do not set suffix = "Touchscreen" */
break;
+ case HID_DG_TOUCHPAD:
+ suffix = "Touchpad";
+ break;
case HID_GD_SYSTEM_CONTROL:
suffix = "System Control";
break;
--
2.5.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD
2015-09-28 14:22 [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD Mika Westerberg
@ 2015-09-29 6:37 ` Daniel Martin
2015-09-29 9:05 ` Benjamin Tissoires
2015-09-29 10:09 ` Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Martin @ 2015-09-29 6:37 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input
On 28 September 2015 at 16:22, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call
> the device as "Touchpad".
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/hid/hid-multitouch.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 426b2f1a3450..661b4fce1a5d 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -968,6 +968,9 @@ static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
> case HID_DG_TOUCHSCREEN:
> /* we do not set suffix = "Touchscreen" */
> break;
> + case HID_DG_TOUCHPAD:
> + suffix = "Touchpad";
> + break;
> case HID_GD_SYSTEM_CONTROL:
> suffix = "System Control";
> break;
> --
I will drop my locally pending patch for this. ;)
Reviewed-by: Daniel Martin <consume.noise@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD
2015-09-28 14:22 [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD Mika Westerberg
2015-09-29 6:37 ` Daniel Martin
@ 2015-09-29 9:05 ` Benjamin Tissoires
2015-09-29 10:09 ` Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Benjamin Tissoires @ 2015-09-29 9:05 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Jiri Kosina, linux-input
On Sep 28 2015 or thereabouts, Mika Westerberg wrote:
> Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call
> the device as "Touchpad".
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/hid/hid-multitouch.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 426b2f1a3450..661b4fce1a5d 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -968,6 +968,9 @@ static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
> case HID_DG_TOUCHSCREEN:
> /* we do not set suffix = "Touchscreen" */
> break;
> + case HID_DG_TOUCHPAD:
> + suffix = "Touchpad";
> + break;
> case HID_GD_SYSTEM_CONTROL:
> suffix = "System Control";
> break;
> --
> 2.5.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD
2015-09-28 14:22 [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD Mika Westerberg
2015-09-29 6:37 ` Daniel Martin
2015-09-29 9:05 ` Benjamin Tissoires
@ 2015-09-29 10:09 ` Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2015-09-29 10:09 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Benjamin Tissoires, linux-input
On Mon, 28 Sep 2015, Mika Westerberg wrote:
> Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call
> the device as "Touchpad".
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied to hid.git#for-4.4/multitouch.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-29 10:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-28 14:22 [PATCH] HID: multitouch: Add suffix for HID_DG_TOUCHPAD Mika Westerberg
2015-09-29 6:37 ` Daniel Martin
2015-09-29 9:05 ` Benjamin Tissoires
2015-09-29 10:09 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).