From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] HID: i2c-hid: Fill in physical device providing HID functionality
Date: Tue, 29 Sep 2015 05:06:18 -0400 [thread overview]
Message-ID: <20150929090618.GC30386@mail.corp.redhat.com> (raw)
In-Reply-To: <1443442508-94971-2-git-send-email-mika.westerberg@linux.intel.com>
On Sep 28 2015 or thereabouts, Mika Westerberg wrote:
> Currently hid_connect() prints out following when I2C connected HID devices
> is connected:
>
> hid-multitouch 0018:03EB:2136.0001: ... [ATML3432:00 03EB:2136] on
>
> After "on " should read physical device name but it is left empty by the
> driver.
>
> Make it look better and fill in the physical device name.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/hid/i2c-hid/i2c-hid.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 2871f3c81a4c..10bd8e6e4c9c 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1028,6 +1028,7 @@ static int i2c_hid_probe(struct i2c_client *client,
>
> snprintf(hid->name, sizeof(hid->name), "%s %04hX:%04hX",
> client->name, hid->vendor, hid->product);
> + strlcpy(hid->phys, dev_name(&client->dev), sizeof(hid->phys));
>
> ret = hid_add_device(hid);
> if (ret) {
> --
> 2.5.1
>
next prev parent reply other threads:[~2015-09-29 9:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 12:15 [PATCH 1/2] HID: Show I2C bus type in hid_connect() Mika Westerberg
2015-09-28 12:15 ` [PATCH 2/2] HID: i2c-hid: Fill in physical device providing HID functionality Mika Westerberg
2015-09-29 6:40 ` Daniel Martin
2015-09-29 9:06 ` Benjamin Tissoires [this message]
2015-09-29 10:07 ` Jiri Kosina
2015-09-29 6:35 ` [PATCH 1/2] HID: Show I2C bus type in hid_connect() Daniel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929090618.GC30386@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).