From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH 2/2] HID: i2c-hid: Fill in physical device providing HID functionality Date: Tue, 29 Sep 2015 05:06:18 -0400 Message-ID: <20150929090618.GC30386@mail.corp.redhat.com> References: <1443442508-94971-1-git-send-email-mika.westerberg@linux.intel.com> <1443442508-94971-2-git-send-email-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53716 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756013AbbI2JGV (ORCPT ); Tue, 29 Sep 2015 05:06:21 -0400 Content-Disposition: inline In-Reply-To: <1443442508-94971-2-git-send-email-mika.westerberg@linux.intel.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Mika Westerberg Cc: Jiri Kosina , linux-input@vger.kernel.org On Sep 28 2015 or thereabouts, Mika Westerberg wrote: > Currently hid_connect() prints out following when I2C connected HID devices > is connected: > > hid-multitouch 0018:03EB:2136.0001: ... [ATML3432:00 03EB:2136] on > > After "on " should read physical device name but it is left empty by the > driver. > > Make it look better and fill in the physical device name. > > Signed-off-by: Mika Westerberg > --- Acked-by: Benjamin Tissoires Cheers, Benjamin > drivers/hid/i2c-hid/i2c-hid.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index 2871f3c81a4c..10bd8e6e4c9c 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -1028,6 +1028,7 @@ static int i2c_hid_probe(struct i2c_client *client, > > snprintf(hid->name, sizeof(hid->name), "%s %04hX:%04hX", > client->name, hid->vendor, hid->product); > + strlcpy(hid->phys, dev_name(&client->dev), sizeof(hid->phys)); > > ret = hid_add_device(hid); > if (ret) { > -- > 2.5.1 >