From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input:gpio-key: set IRQF_NO_SUSPEND for wake capable key Date: Fri, 2 Oct 2015 10:41:46 -0700 Message-ID: <20151002174146.GB8437@dtor-ws> References: <1442506019-13687-1-git-send-email-qipeng.zha@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:33566 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbbJBRlt (ORCPT ); Fri, 2 Oct 2015 13:41:49 -0400 Received: by pacex6 with SMTP id ex6so112274513pac.0 for ; Fri, 02 Oct 2015 10:41:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Linus Walleij Cc: Qipeng Zha , Linux Input , Qi Zheng , Aubrey Li On Fri, Oct 02, 2015 at 03:26:27AM -0700, Linus Walleij wrote: > On Thu, Sep 17, 2015 at 9:06 AM, Qipeng Zha wrote: > > > When wakeup attribute is set, GPIO key is supposed to wake up > > the system from system sleep state, So set IRQF_NO_SUSPEND > > flag to keep IRQ enabled during suspend. > > > > Signed-off-by: Qi Zheng > > Signed-off-by: Aubrey Li > > Signed-off-by: Qipeng Zha > > Reviewed-by: Linus Walleij > > Should this not be tagged for stable? I do not believe we need this at all. Otherwise every single driver for devices that might be wakeup sources needs this flag set. Which would basically means it is a noop and we should not suspend IRQ threads by default. The dirver correctly calls enable_irq_wake() and platform should do whatever it needs to make sure wakeup interrupt will be serviced. Thanks. -- Dmitry